Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker support #1187

Closed
wants to merge 1 commit into from
Closed

Add docker support #1187

wants to merge 1 commit into from

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Nov 5, 2017

This PR adds support for Docker. This is intended to easy the initial set-up of the environment and requirements for recurring and first-time contributors alike. The advantage of using this approach is that the developer does not need to install and configure postgresql, ruby, python3.4 and all python packages locally, effectively simplifying the installation and set up of the environment. Also, if the environment is not needed, is very easy to clean.

To install all dependencies and start the containers:

  1. Install docker and docker-compose

  2. docker-compose up --build

The first set up will take a while, but after that everything will be cached and therefore new instantiation of the containers will take much less time.

  1. Access the webpage on localhost:8000.

  2. Profit! 馃挵

If you want to change anything in the project and see the result, just re-run docker-compose up --build again. Take into account that this will NOT reset the database. If you want to start truly clean, run docker-compose rm first to remove the previous containers.


One of the main targets of using this approach is to make much easier to set up everything for new developers and contributors, no mater if they use Windows, Linux or MacOS as long as they can run docker.

@pablogsal pablogsal force-pushed the dockerfile branch 2 times, most recently from e5875bd to 89617c0 Compare November 5, 2017 20:19
Copy link
Member

@berkerpeksag berkerpeksag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, but we already have a way to install development environment without installing all dependencies in contributor's system: https://pythondotorg.readthedocs.io/install.html#easy-setup-using-vagrant

I personally prefer Vagrant + Ansible setup since it doesn't require users to upgrade their Kernel version frequently (I can't run Docker in my system because its Kernel version is too old for Docker -- I definitely won't upgrade it just because of Docker) and they are more stable than Docker.

@Nathanator
Copy link
Contributor

Yeah, I too think Docker is too heavyweight for most tasks. Ever tried to get Docker working out of the box on Ubuntu? It's not trivial or easy. If fixing a typo is harder than git clone && nano, we're going to suffer, IMHO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants