New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some HTTP to HTTPS. #1234
Some HTTP to HTTPS. #1234
Conversation
users/tests/test_models.py
Outdated
@@ -60,12 +60,12 @@ def test_create_usergroup(self): | |||
group = UserGroup.objects.create( | |||
name='PLUG', | |||
location='London, UK', | |||
url='http://meetup.com/plug', | |||
url='https://meetup.com/plug', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a test, no need to change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, I however though it would be good to have some https in tests just in case it break something. But it should better be separated tests in this case so I revert this one OK.
templates/python/inner.html
Outdated
{% include "components/navigation-widget.html" %} | ||
|
||
<div class="twitter-widget sidebar-widget"> | ||
<script type="text/javascript" src="http://widgets.twimg.com/j/2/widget.js"></script> | ||
<script type="text/javascript" src="https://widgets.twimg.com/j/2/widget.js"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would better to use the same style in both this file and templates/waitforit.html
(//...
was used instead of https://...
there)
templates/python/inner.html
Outdated
@@ -623,11 +623,11 @@ <h1 id="form">Form Example</h1> | |||
|
|||
{% block left_sidebar %} | |||
<aside class="left-sidebar" role="secondary"> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated change.
@@ -8,7 +8,7 @@ D-Link Australia Uses Python to Control Firmware Updates | |||
:Author: How Wong | |||
:Contact: grandsonata at aol dot com | |||
:Date: 2007/08/02 10:00:00 | |||
:Web site: http://www.dlink.com.au/ | |||
:Web site: https://www.dlink.com.au/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is used by the test suite, no need to change.
@@ -31,29 +31,29 @@ Python is powerful... and fast | |||
------------------------------ | |||
|
|||
Fans of Python use the phrase "batteries included" to describe the | |||
`standard library <http://docs.python.org/3/library/>`_, which covers | |||
`standard library <https://docs.python.org/3/library/>`_, which covers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is used by the test suite, no need to change.
@@ -42,7 +42,7 @@ def initial_data(): | |||
<p>Experienced programmers in any other language can pick up Python very | |||
quickly, and beginners find the clean syntax and indentation structure | |||
easy to learn. | |||
<a href=\"http://docs.python.org/3.3/tutorial/\">Whet your appetite</a> | |||
<a href=\"https://docs.python.org/3/tutorial/\">Whet your appetite</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file creates data for development purposes. No need to change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not having up-to-date links in dev too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test data in codesamples/factories.py is basically for frontend developers to see the slider in action, but sure let's update it.
blogs/tests/test_models.py
Outdated
@@ -9,7 +9,7 @@ class BlogModelTest(TestCase): | |||
def test_translation(self): | |||
t = Translation.objects.create( | |||
name='Swiss', | |||
url='http://python.ch', | |||
url='https://python.ch', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a test, no need to change.
blogs/tests/test_models.py
Outdated
@@ -21,7 +21,7 @@ def test_blog_entry(self): | |||
title='Test Entry', | |||
summary='Test Summary', | |||
pub_date=now, | |||
url='http://www.revsys.com', | |||
url='https://www.revsys.com', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a test, no need to change.
Thanks. |
While shaving a yak I though it was a good idea to proofread some old links.