Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show sign in box in PSF pages. #730

Merged
merged 1 commit into from Aug 10, 2017

Conversation

berkerpeksag
Copy link
Member

Fixes #536.

@Mariatta
Copy link
Member

I think this works and definitely agree that the sign in box should only appear where it needs to be.

My only concern is that this creates inconsistency with the placement of the search textbox.
In most pages the search box will be more to the right of the page, whereas in the PSF page, where the sign in page is shown, it will be slightly to the left.

Perhaps not a big deal though, but then again maybe not my call.
Is there anyone who can provide input on this?

Thanks.

@berkerpeksag
Copy link
Member Author

With this PR applied, screenshot of the homepage:

screenshot from 2017-08-10 23 01 34

Screenshoot of the PSF landing page:

screenshot from 2017-08-10 23 03 36

@MarkMangoba
Copy link
Contributor

@berkerpeksag amazing looks so much cleaner.

@berkerpeksag
Copy link
Member Author

I noticed a bug. I think we should still show "Your account" link in every page if user is already logged in:

screenshot from 2017-08-10 23 13 58

I've fixed it in the latest version of the PR.

@berkerpeksag berkerpeksag merged commit 83bf98a into python:master Aug 10, 2017
@berkerpeksag berkerpeksag deleted the 536-login branch August 10, 2017 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move sign in dialog to the community page
3 participants