This repository has been archived by the owner on Jul 5, 2023. It is now read-only.
Support text appearing after "# type: ignore" #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failure is because we still do 3.4 windows builds so I'm gonna put up a PR to turn those off and then rebase this |
This is to allow things like `# type: ignore[E1000]`. Essentially a backport of GH-13238, GH-13479, and GH-13504 from cpython.
ilevkivskyi
approved these changes
Jun 2, 2019
|
Whoops, I missed this somehow. It'll take some time to review carefully. Maybe we can do another typed_ast release after this has landed? The release process is pretty straightforward and there are working instructions in in release_process.md. |
gvanrossum
approved these changes
Jun 4, 2019
|
The tests live in the |
msullivan
added a commit
to msullivan/pyflakes
that referenced
this pull request
Jul 19, 2019
This is to support allowing typecheckers to implement ignores for specific errors, using syntax like `# type: ignore=E1000` or `# type: ignore[type-mismatch` or some such. mypy is about to add support for ignoring specific errors following this design: python/mypy#7239 Support for extra text in type comments was implemented in CPython as https://bugs.python.org/issue36878 and in typed_ast as python/typed_ast#116.
msullivan
added a commit
to msullivan/pyflakes
that referenced
this pull request
Jul 19, 2019
This is to support allowing typecheckers to implement ignores for specific errors, using syntax like `# type: ignore=E1000` or `# type: ignore[type-mismatch` or some such. mypy is about to add support for ignoring specific errors following this design: python/mypy#7239 Support for extra text in type comments was implemented in CPython as https://bugs.python.org/issue36878 and in typed_ast as python/typed_ast#116.
msullivan
added a commit
to msullivan/pyflakes
that referenced
this pull request
Jul 19, 2019
This is to support allowing typecheckers to implement ignores for specific errors, using syntax like `# type: ignore=E1000` or `# type: ignore[type-mismatch` or some such. mypy is about to add support for ignoring specific errors following this design: python/mypy#7239 Support for extra text in type comments was implemented in CPython as https://bugs.python.org/issue36878 and in typed_ast as python/typed_ast#116.
sigmavirus24
pushed a commit
to PyCQA/pyflakes
that referenced
this pull request
Aug 12, 2019
* In PEP 484 type comments, allow text after "# type: ignore" This is to support allowing typecheckers to implement ignores for specific errors, using syntax like `# type: ignore=E1000` or `# type: ignore[type-mismatch` or some such. mypy is about to add support for ignoring specific errors following this design: python/mypy#7239 Support for extra text in type comments was implemented in CPython as https://bugs.python.org/issue36878 and in typed_ast as python/typed_ast#116. * add test back
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to allow things like
# type: ignore[E1000].Essentially a backport of GH-13238, GH-13479, and GH-13504 from cpython.