In PEP 484 type comments, allow text after "# type: ignore" #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msullivan
force-pushed
the
nicer-type-ignore
branch
from
141947f
to
e6905ee
Compare
This is to support allowing typecheckers to implement ignores for specific errors, using syntax like `# type: ignore=E1000` or `# type: ignore[type-mismatch` or some such. mypy is about to add support for ignoring specific errors following this design: python/mypy#7239 Support for extra text in type comments was implemented in CPython as https://bugs.python.org/issue36878 and in typed_ast as python/typed_ast#116.
msullivan
force-pushed
the
nicer-type-ignore
branch
from
e6905ee
to
b9267e1
Compare
asottile
reviewed
Jul 19, 2019
The-Compiler
added a commit
to qutebrowser/qutebrowser
that referenced
this pull request
Sep 26, 2019
We can't use specific type ignores yet as there is no pyflakes release with this change in: PyCQA/pyflakes#455
wsanchez
added a commit
to twisted/klein
that referenced
this pull request
Oct 28, 2019
|
Any release planned so we can see this fix on PyPI? |
not yet, please be patient (this comment is not productive) we'll release when we're ready! |
wsanchez
added a commit
to python-hyper/hyperlink
that referenced
this pull request
Nov 19, 2019
Clean up some type hints.
blueyed
referenced
this pull request
in python/mypy
Jan 15, 2020
This PR enables `--strict-equality` and `--show-error-codes` for self-check, and adds error codes in some `# type: ignore`s. So far this revealed two issues: * Both PyCharm and flake8 get crazy about error codes, generating many false positives * Error codes in `# type: ignore`s don't always work, see #7384
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Jan 15, 2020
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Jan 17, 2020
Ref: PyCQA/pyflakes#455 (cherry picked from commit 2393b58)
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Jan 17, 2020
Ref: PyCQA/pyflakes#455 (cherry picked from commit 2393b58)
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Jan 17, 2020
Ref: PyCQA/pyflakes#455 (cherry picked from commit 2393b58)
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Jan 17, 2020
Closed
twm
added a commit
to twm/hyperlink
that referenced
this pull request
Dec 22, 2020
This release includes PyCQA/pyflakes#455
twm
added a commit
to twm/hyperlink
that referenced
this pull request
Dec 22, 2020
This release includes PyCQA/pyflakes#455
3 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to support allowing typecheckers to implement ignores for
specific errors, using syntax like
# type: ignore=E1000or# type: ignore[type-mismatch]or some such.mypy is about to add support for ignoring specific errors following
this design: python/mypy#7239
Support for extra text in type comments was implemented
in CPython as https://bugs.python.org/issue36878
and in typed_ast as python/typed_ast#116.