Skip to content
This repository has been archived by the owner on Jul 5, 2023. It is now read-only.

Use Github Actions + cibuildwheel for all wheels #163

Merged
merged 5 commits into from
Oct 11, 2021

Conversation

hauntsaninja
Copy link
Collaborator

Besides reducing the number of places wheels end up, cibuildwheel does nice things like run auditwheel for you. We also run check-manifest so our sdist is more reliably packaged. Updates to documentation.

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good!

AppVeyor was running the tests, should GHA run tests too?

And can .travis.yml be removed?


on:
push:
branches: [master]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend removing this branch restriction, so contributors can test their feature branches before opening PRs.

Relatedly, do you have an example build?

release_process.md Outdated Show resolved Hide resolved
hauntsaninja and others added 3 commits October 10, 2021 22:03
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@hauntsaninja
Copy link
Collaborator Author

Thanks for the feedback!

Example build here: https://github.com/hauntsaninja/typed_ast/actions/runs/1327600384
I changed things to also run tests, so now we can get rid of travis.
I put in the branch restriction because I had the workflow create a github release containing the wheels. But that's more useful for the project I was basing this off of, for typed_ast we can just go to the relevant github actions page and download the artifacts.

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!


It's also possible to upload the sdist+wheels to PyPI as part of a release (e.g. tag) using something like https://github.com/pypa/gh-action-pypi-publish, but I'd suggest leaving that for a followup and making a release first with this.

@srittau srittau merged commit 7fc8aec into python:master Oct 11, 2021
@hauntsaninja hauntsaninja deleted the gabuild branch October 11, 2021 19:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants