pkg_resources: Remove type-only _Importer class
#11512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
commented
Feb 29, 2024
| _NSHandlerType: TypeAlias = Callable[[_Importer, str, str, types.ModuleType], str] | ||
| _ModuleLike: TypeAlias = object | types.ModuleType # Any object that optionally has __loader__ or __file__, usually a module | ||
| _ProviderFactoryType: TypeAlias = Callable[[_ModuleLike], IResourceProvider] | ||
| _DistFinderType: TypeAlias = Callable[[_T, str, bool], Iterable[Distribution]] |
There was a problem hiding this comment.
If it wasn't for the find_nothing method that returns an empty tuple, this would be correct in returning a Generator.
https://github.com/pypa/setuptools/blob/8c45d6e445a8ca5f5a1fd724a80a5c418fe36780/pkg_resources/__init__.py#L2092-L2093
xref pypa/setuptools#4249
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Closed
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #11455
As I was attempting to merge stubs directly into
pkg_resources(setuptools repo), I couldn't figure out what_Importerwas actually supposed to be.After working through the
register_*methods, I think I've figured out the correct typing