Made pkg_resoursces.NullProvider's has_metadata and metadata_isdir methods return actual booleans like all other Providers
#4254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ir` methods return actual booleans like all other Providers
Avasam
force-pushed
the
boolean-has_metadata-&-metadata_isdir
branch
from
752fe1d
to
56bd481
Compare
Avasam
added a commit
to Avasam/typeshed
that referenced
this pull request
Mar 4, 2024
|
Thank you very much @Avasam. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Made
pkg_resoursces.NullProvider'shas_metadataandmetadata_isdirmethods return actual booleans like all other Providers.This was noticed when attempting to type the
pkg_resourcespackage for #2345xref python/typeshed#11512 (comment)
Pull Request Checklist
newsfragments/.(See documentation for details)