Add third-party six package
#21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops, forgot to run the checks on the final version, will fix and rebase in a bit. |
|
Okay, done now, except that some of the modules needed by |
|
It looks like all the review comments are for the |
This was referenced Oct 29, 2015
Merged
|
I believe I've addressed all the review comments now, except that if this is merged now a lot of tests will fail, until #22 is finished. |
|
Yep, this still makes a lot of mypy tests fail. |
timabbott
added a commit
to timabbott/typeshed
that referenced
this pull request
Jan 26, 2016
timabbott
added a commit
to timabbott/typeshed
that referenced
this pull request
Jan 26, 2016
timabbott
added a commit
to timabbott/typeshed
that referenced
this pull request
Jan 26, 2016
timabbott
added a commit
to timabbott/typeshed
that referenced
this pull request
Jan 27, 2016
timabbott
added a commit
to timabbott/typeshed
that referenced
this pull request
Jan 27, 2016
Closed
gvanrossum
changed the title
six package and finish typessix package
|
Closing this since it's out of date; however I'm keeping a pointer in #66 just in case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things of note:
typesis now complete, it still needs special handling in checkers. Some of this might already be possible withtyping, but some of it is certainly not.six.movesuse the.pyextension so they can use glob exports, sincesys.modulestrickery is out of scope for tools that use stubs.imp.reloadandimportlib.reloadin python 3.4+, the signature is the same.2and3now (this was actually my motivation).