Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stubs for contextvars backport (3.5 and 3.6) #2378

Merged
merged 2 commits into from
Aug 14, 2018

Conversation

stevenjackson121
Copy link
Contributor

Permission from repo maintainer: MagicStack/contextvars#10

python tests/mypy_selftest.py fails when I try running it locally with the same summary (4 failed, 6349 passed, 164 skipped) both before and after this change.

python tests/mypy_test.py passes and I believe python tests/pytype_test.py is only applicable for python2.

@stevenjackson121
Copy link
Contributor Author

This failure looks to me like a failure with Travis-CI config and not a problem with the PR: https://travis-ci.org/python/typeshed/jobs/414689751 (Copied below for convenience)

3.6-dev is not installed; attempting download
Downloading archive: https://s3.amazonaws.com/travis-python-archives/binaries/ubuntu/14.04/x86_64/python-3.6-dev.tar.bz2
$ curl -sSf -o python-3.6-dev.tar.bz2 ${archive_url}
curl: (56) SSL read: error:00000000:lib(0):func(0):reason(0), errno 104
Unable to download 3.6-dev archive. The archive may not exist. Please consider a different version.

If this is not the case please let me know how I could go about troubleshooting the cause.

@JelleZijlstra
Copy link
Member

I restarted the flake8 build.

It is not true that the pytype test is only applicable to Python 2; it runs pytype, which runs under Python 2, but it also checks the Python 3 stubs.

Could you add this file to tests/check_consistent.py to make sure we keep the stdlib and third-party versions in sync?

@stevenjackson121
Copy link
Contributor Author

Thanks for the restart and the information @JelleZijlstra !

I added contextvars to tests/check_consistent.py as requested. Let me know if there's anything else I should do!

@stevenjackson121
Copy link
Contributor Author

Ping :)

@JelleZijlstra JelleZijlstra merged commit 80a0a75 into python:master Aug 14, 2018
yedpodtrzitko pushed a commit to yedpodtrzitko/typeshed that referenced this pull request Jan 23, 2019
* Add stubs for contextvars backport (3.5 and 3.6)

* Add contextvars to tests/check_consistent.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants