Let ctypes._CData.from_buffer[_copy] accept any buffer object #2610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the issue discussed here: python#1906 (comment)
eric-wieser
approved these changes
Nov 20, 2018
|
Relevant: python/typing#593. |
JelleZijlstra
approved these changes
Nov 20, 2018
|
This seems OK for now; we may have to tweak it if/when we add buffer support to |
yedpodtrzitko
pushed a commit
to yedpodtrzitko/typeshed
that referenced
this pull request
Jan 23, 2019
…#2610) Fixes the issue discussed here: python#1906 (comment)
hauntsaninja
pushed a commit
to hauntsaninja/typeshed
that referenced
this pull request
Jan 30, 2020
Follows the approach in python#2610
hauntsaninja
pushed a commit
to hauntsaninja/typeshed
that referenced
this pull request
Feb 5, 2020
Follows the approach in python#2610
JelleZijlstra
pushed a commit
that referenced
this pull request
Feb 22, 2020
* fcntl: mark positional-only args * fcntl: use overload for fcntl.fcntl The comment about depending on the type of arg seems incorrect bf50135 I checked the docs and examples, CPython implementation and CPython tests, but I might be missing something * fcntl: use overload for fcntl.ioctl Based off of docs and examples * fcntl: type buffers better Follows the approach in #2610
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue discussed here: #1906 (comment)