New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mmap as a valid buffer type. #2895

Merged

srittau merged 1 commit into python:master from alexchamberlain:mmap

Mar 30, 2019

Contributor

alexchamberlain commented Mar 30, 2019

Currently seeing the following error from mypy, which I think this should solve:

foo.py:47: error: Argument 1 to "pack_into" of "Struct" has incompatible type "mmap"; expected "Union[array[Any], bytearray, memoryview]"


          Add mmap as a valid buffer type.

da36cae

srittau approved these changes

View reviewed changes

Collaborator

srittau left a comment

Thanks. This also relates to python/typing#593

srittau merged commit f11d061 into python:master

srittau mentioned this pull request

Buffer protocol types python/typing#593

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet