add zipfile for py2 #345
Merged
add zipfile for py2 #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| class BadZipFile(Exception): ... | ||
|
|
||
| if sys.version_info > (3,): | ||
| BadZipfile = ... # type: Type[BadZipFile] |
There was a problem hiding this comment.
It might be easier to just say
BadZipfile = BadZipFile
There was a problem hiding this comment.
True, it's clearer.
tharvik
force-pushed
the
improve_zipfile
branch
2 times, most recently
from
0298144
to
14f290f
Compare
| @@ -0,0 +1,94 @@ | |||
| # Stubs for zipfile (Python 3.4) | |||
There was a problem hiding this comment.
Why have this comment here if this is supposed to be 2and3?
There was a problem hiding this comment.
Because typo, it from stubgen but I forgot to remove it, it is amended now.
|
Can you fix the failing 2.7 tests? |
|
Feel free to add "zipfile" to the pytype test blacklist for the time being, if that makes things easier. |
|
Opened pytype#28, added zipfile to blacklist for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove py3 specific zipfile, rewrite it from doc.