Minor fixes to cryptography (x509 and friend) #3520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srittau
reviewed
Dec 3, 2019
|
|
||
| class IssuerAlternativeName(ExtensionType): | ||
| def __init__(self, general_names: List[GeneralName]) -> None: ... | ||
| def __iter__(self) -> Generator[GeneralName, None, None]: ... | ||
| def get_values_for_type(self, type: Type[GeneralName]) -> Generator[GeneralName, None, None]: ... |
There was a problem hiding this comment.
As far as I can see in the implementation, this (and the one below) just delegate to GeneralNames.get_values_for_type(), which just returns a list of the values from the GeneralNames. So shouldn't the return value be List[Any]?
There was a problem hiding this comment.
Good eye! I was so focused on the arguments, I didn't scrutinize the return.
It is a list, and you are correct, only another Any will do :/ . It could be Union[Any, OtherName] but that seems superfluous. updated patch (squashed for not polluting the history)
srittau
approved these changes
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a few corrections that I believe are warranted.
CertificateSigningRequest.public_bytes() takes an encoding parameter in the base class
GeneralName has a value property in the base class
Extensions.get_extension_by_class() takes a Class, not an instance of Extension as argument
Add get_values_for_type() method to several SubjectAlternativeName/IssuerAlternativeName , which also takes a Class, not instance argument class
I'm kinda new to typing, so I believe Type[] is the proper way to specify Class vs instance.
Also, I don't like using Any for value, but I think that's appropriate here.
Fixes #3519