Update int.from_bytes to allow Iterable[int] #3571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluetech
approved these changes
Jan 4, 2020
There was a problem hiding this comment.
The argument actually accepts more things, like SupportsBytes and buffer-protocol types (as the TODO says). I'm not sure how typeshed handles the C buffer protocol, but at least SupportsBytes can be added.
But this is already an improvement so LGTM either way.
`int.from_bytes` supports both iterables of ints and objects that define __bytes__'. As an example `int.from_bytes(iter([1, 0]), 'little'))` returns 1.
armooo
force-pushed
the
armooo-from-bytes
branch
from
3a07278
to
3f7aad3
Compare
|
python/typing#593 is the relevant issue for the buffer protocol. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
int.from_bytes(iter([1, 0]), 'little'))returns 1 asexpected.