Additional type information for asyncio #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Could you fix the issues discovered by Travis CI? |
|
I am checking on the error |
added 2 commits
February 10, 2016 22:09
Add the appropriate types for AbstractServer in asyncio.events. wait_closed() is a couroutine, however in the implementation of AbstractServer not marked as such. We are adding the couroutine defintion here anyway, as we do want to make it typeable as a coroutine if necessary.
|
Try something like |
|
This seems to have been caused by absolute imports having mypy's internal typeshed information pulled in, which conflicts. @gvanrossum thanks for the hint, much appreciated. |
gvanrossum
added a commit
that referenced
this pull request
Feb 20, 2016
Additional type information for asyncio
|
Thanks again! |
Closed
momandine
pushed a commit
to momandine/typeshed
that referenced
this pull request
Jul 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds more type information for asyncio.
I've tested this against a small code library internally that was written in Python 3.5 and uses asyncio.subprocess. I tested this with mypy at 9befcc7.
I am sure some of the types need refinement as this is the first time I am working with typeshed and typed python.