-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type error in typing._get_type_vars() for Dict[typing.Callable[..., str], str] #259
Comments
Is this Python 3.5.2 or older? --Guido (mobile) On Aug 4, 2016 1:47 AM, "Libor Jonát" notifications@github.com wrote:
|
It's 3.5.2. I can't replicate this in 3.5.1. |
OK, thanks! Should be easy to fix. |
Was this fixed? Getting it here: https://travis-ci.org/ActivityWatch/activitywatch/jobs/241466478 |
@ErikBjare I have no idea which version of Python/ |
@ErikBjare OK, I see you are using 3.5.2 in CI, then you need to either upgrade to 3.5.3, or (if not possible) use quoted annotations |
There's a problem with python 3.5.2 and earlier when it comes to some dependencies on the master branch (3.5.0 at this point). Something related to python/typing#259 and of course xenial only pulls in 3.5.2. We stick to xenial because of 3.3.x/3.4.x...i guess we'd have to do equally oddball things to the docker image if we went to bionic so this change seems like the one of least effort. CTR
When using typing for
Dict
where key or value can beCallable
which hasEllipsis
in argument it leads toTypeError: 'ellipsis' object is not iterable
.Example:
Input:
Output:
This happens even on
master
. First saw inpython 3.5.2
.The text was updated successfully, but these errors were encountered: