Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typing_extensions crash on Python 3.5.0 - 3.5.2 if used together with collections.abc #501

Closed
ilevkivskyi opened this issue Nov 24, 2017 · 0 comments · Fixed by #503
Closed

typing_extensions crash on Python 3.5.0 - 3.5.2 if used together with collections.abc #501

ilevkivskyi opened this issue Nov 24, 2017 · 0 comments · Fixed by #503
Assignees
@ilevkivskyi

Comments

@ilevkivskyi
Copy link
Member

Originally reported in dropbox/pyannotate#36

A simple repro

import typing_extensions
import collections.abc
isinstance(1, collections.abc.Mapping)

leads to a recursion error like this: https://travis-ci.org/ilevkivskyi/typehinting/jobs/306766341
@ilevkivskyi ilevkivskyi self-assigned this Nov 24, 2017
@ilevkivskyi ilevkivskyi mentioned this issue Nov 25, 2017
Merged
ilevkivskyi added a commit that referenced this issue Dec 1, 2017
@ilevkivskyi
Fix interaction between typing_extensions and collections.abc (#503)
5911b7e 
Fixes #501

The idea is straightforward: special classes in typing_extensions
that have __extra__ should use a metaclass that fixes the problem in
GenericMeta.__subclasscheck__ on older versions of typing.

Note that overriding __subclasscheck__ tries to mimic the behaviour
in the new versions of typing. (I can't just use super().__subclasscheck__
on unaffected versions, since this changes call stack depth and therefore
breaks a sys._getframe hack on some other versions of typing.)
@ksunden ksunden mentioned this issue Aug 27, 2018
Closed
@srittau srittau mentioned this issue May 12, 2022
Closed
This was referenced May 21, 2024
Merged
Merged
Merged
@github-actions github-actions bot mentioned this issue Jun 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilevkivskyi ilevkivskyi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix interaction between typing_extensions and collections.abc ilevkivskyi/typehinting
1 participant
@ilevkivskyi