Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unbreak broken tutorials and pytest for tutorials #1653

Merged
merged 37 commits into from
Apr 4, 2023
Merged

Unbreak broken tutorials and pytest for tutorials #1653

merged 37 commits into from
Apr 4, 2023

Conversation

Ibrahim2750mi
Copy link
Contributor

@Ibrahim2750mi Ibrahim2750mi commented Mar 21, 2023 •
edited
Loading

Unbreak(if broken) the following tutorials:

  • card game
  • compute shader
  • crt filter
  • framebuffer
  • gpu_particle_burst
  • lights
  • pymunk platformer
  • raycasting
  • shader inputer
  • shader toy glow
  • shader toy particles
  • views

Skipped tutorials:

  • pyinstaller
  • compiling with nutika
  • platfrom tutorials (source code present in examples to be looked over by Clepto)

@Ibrahim2750mi Ibrahim2750mi marked this pull request as draft March 21, 2023 20:32
@Ibrahim2750mi Ibrahim2750mi changed the title Unbreak card-game tutorial Unbreak broken tutorials Mar 21, 2023
@Ibrahim2750mi
Copy link
Contributor Author

Currently blocked by #1656

@Ibrahim2750mi Ibrahim2750mi marked this pull request as ready for review March 25, 2023 09:02
pushfoo
pushfoo approved these changes Mar 25, 2023
View reviewed changes
Copy link
Member

@pushfoo pushfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The use of SpriteList.swap is a nice touch. Good attention to detail. 👍

@Ibrahim2750mi Ibrahim2750mi changed the title Unbreak broken tutorials Unbreak broken tutorials and pytest for tutorials Mar 25, 2023
@Ibrahim2750mi Ibrahim2750mi requested review from pvcraven and pushfoo and removed request for pvcraven and pushfoo March 25, 2023 23:06
Ibrahim2750mi and others added 12 commits March 30, 2023 08:26
@pushfoo pushfoo mentioned this pull request Apr 4, 2023
Merged
@Ibrahim2750mi
Copy link
Contributor Author

@pushfoo Thanks for the co-author.

@pvcraven pvcraven merged commit aa854d6 into pythonarcade:development Apr 4, 2023
@pvcraven
Copy link
Member

pvcraven commented Apr 4, 2023

Thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@einarf einarf einarf left review comments

@pushfoo pushfoo pushfoo approved these changes

@gran4 gran4 gran4 left review comments

@pvcraven pvcraven pvcraven approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Ibrahim2750mi @pvcraven @einarf @pushfoo @gran4