Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add __len__ and __delitem__ to Scene #1721

Merged
merged 2 commits into from
Apr 24, 2023
Merged

Add __len__ and __delitem__ to Scene #1721

merged 2 commits into from
Apr 24, 2023

Conversation

tiffanyxiao
Copy link
Contributor

For Issue#1651

What was done

  • Added __len__ and __delitem__ methods to scene.py.
  • Added tests for these new scene methods.

How to test

  • Run the pytests; both tests should pass (the individual tests are in tests/unit/scene/test_scene_len_delitem.py).

Special thanks to @Cleptomania for the hands on help at PyCon 2023!

@Cleptomania Cleptomania merged commit cf13697 into pythonarcade:development Apr 24, 2023
5 checks passed
gran4
gran4 reviewed Apr 24, 2023
View reviewed changes
Copy link
Contributor

@gran4 gran4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that it looks good to me.

arcade/scene.py Show resolved Hide resolved
@tiffanyxiao tiffanyxiao mentioned this pull request Apr 24, 2023
Merged
@pushfoo pushfoo mentioned this pull request Apr 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cleptomania Cleptomania Cleptomania left review comments

@gran4 gran4 gran4 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tiffanyxiao @Cleptomania @gran4