Moved moving platforms code #1759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the moving platforms before moving the player. That way, the player's movement is up to date with the platform's position.
|
Hi, could you look at the failing test? I think the code has some issues with number of blank lines for PEP-8 compliance. |
gran4
reviewed
May 8, 2023
|
This PR still needs the whitespace fix before merge. |
|
Fixed lingering issue. Thanks for the PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the moving platforms before moving the player. That way, the player's movement is up to date with the platform's position.
Without this change, the player seems to float on or sink into the platform by a few pixels.