Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera Overhaul #1881

Closed

Commits on Jun 10, 2023

  1. Setup primary files for experimental refactor of the Camera, Backgrou…

    …nds, and Scenes.
    
    See the
    #Possible Scene Improvements
    #Cameras
    topics in the arcade-dev forum on the Python Arcade discord server.
    DragonMoffon committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    11cc5c7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fa06bc2 View commit details
    Browse the repository at this point in the history
  3. Completed the Camera2DOrthographic class with doc strings and comment…

    …s, and started the Camera2DController, and SimpleCamera classes.
    
    See the
    #Possible Scene Improvements
    #Cameras
    topics in the arcade-dev forum on the Python Arcade discord server for more info.
    DragonMoffon committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    882c83b View commit details
    Browse the repository at this point in the history
  4. Slight change to Cameras to allow for a perspective projection matrix…

    …. Created basic Perspective and Orthographic Cameras.
    
    See the
    #Possible Scene Improvements
    #Cameras
    topics in the arcade-dev forum on the Python Arcade discord server for more info.
    DragonMoffon committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    17d1a9b View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. Completed Orthographic Camera. Had some issues with the view matrix, …

    …This has been fixed and applied to both of the base cameras. Added a new get map coordinates function (open to change). Placed framework for backwards compatible simple camera.
    
    See the
    #Possible Scene Improvements
    #Cameras
    topics in the arcade-dev forum on the Python Arcade discord server for more info.
    DragonMoffon committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    369545a View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2023

  1. Update camera_refactor.py

    Finished Simple Camera. Is backwards compatible with current Simple Camera implementation.
    DragonMoffon committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    1540f60 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2023

  1. PR cleanup

    Cleaning up PR to only include camera refactor
    DragonMoffon committed Jun 18, 2023
    Configuration menu
    Copy the full SHA
    23041b2 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2023

  1. New Camera Code Integration

    Moved experimental code into new "cinematic" folder within arcade.
    
    Also made the default camera in arcade the "DefaultCamera" class. and made it's type be "Projector"
    DragonMoffon committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    dd7531c View commit details
    Browse the repository at this point in the history
  2. Code inspection Clean up

    DragonMoffon committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    7bcc802 View commit details
    Browse the repository at this point in the history
  3. Inspection Fix 2

    DragonMoffon committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    f573ba8 View commit details
    Browse the repository at this point in the history
  4. Code inspection fix 3

    DragonMoffon committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    c741d08 View commit details
    Browse the repository at this point in the history
  5. Round 4

    DragonMoffon committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    d4e6be5 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. Writitng initial Unit Tests

    Created files for unit tests, and wrote a few.
    
    Started work on Camera2D (replacement for simple camera)
    DragonMoffon committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    05b624e View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. Configuration menu
    Copy the full SHA
    cd3469d View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. Finished base of Camera2D class.

    The basics for Camera2D have been provided with full doc strings. Other helper methods may be added in the future.
    DragonMoffon committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    b3900c0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ebbc606 View commit details
    Browse the repository at this point in the history
  3. code-inspection clean-up on Camera2D

    Fixed `mypy`, `pyright`, `ruff` errors.
    
    Also added __all__ property to every file
    for a better importing experience.
    
    NOTE arcade/camera.py is still there, and it does not match the current system so the code-inspection still complains. Will resolve later.
    DragonMoffon committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    b3aed09 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Removed all reference to old camera system.

    This included deleting `arcade/camera.py`, and fixing the ui and sections to use either the Default Ortho Projector.
    
    NOTE I removed a quick index to the `camera.rst`. That will need to be fixed.
    
    Hey look I linted before pushing for once!
    DragonMoffon committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    16bc0b9 View commit details
    Browse the repository at this point in the history
  2. whoops circular imports

    DragonMoffon committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    69d81c2 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. circular imports 2

    DragonMoffon committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    756297d View commit details
    Browse the repository at this point in the history
  2. type checking

    DragonMoffon committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    eb40fba View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. Started work on some controllers

    Made a few function controllers which are mega simple.
    
    Also changed name from arcade.cinematic to arcade.camera.
    
    Also moved the controllers to arcade.camera.controllers.
    DragonMoffon committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    7068c5f View commit details
    Browse the repository at this point in the history
  2. fixing silly pycharm muck-up

    when I changed the file name it didn't update any imports tsk tsk.
    DragonMoffon committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    04b6a41 View commit details
    Browse the repository at this point in the history
  3. removing doc ref

    Have not setup camera documentation so removing old ref.
    
    DO NOT PULL PR UNTIL FIXED.
    DragonMoffon committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    8d7dd21 View commit details
    Browse the repository at this point in the history
  4. Updated Orthographic Unit Tests

    grrrrr pycharm
    DragonMoffon committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    0bc95ea View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2023

  1. Fixed all the examples

    NOTE this is a quick fix. It removed shaking from two examples. CANNOT BE PULLED IN WHILE THIS IS UNRESOLVED.
    
    Weirdly the linters didn't pick up on these errors
    DragonMoffon committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    61dbbab View commit details
    Browse the repository at this point in the history
  2. linting fix 1-million

    DragonMoffon committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    10c6a70 View commit details
    Browse the repository at this point in the history
  3. 1-million and 1

    DragonMoffon committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    bff0c03 View commit details
    Browse the repository at this point in the history
  4. 1-million and 2

    DragonMoffon committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    da72942 View commit details
    Browse the repository at this point in the history
  5. MOAR example fixing

    DragonMoffon committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    e2b1693 View commit details
    Browse the repository at this point in the history
  6. Setup 4 Splines for SplineController

    setup lerp, quadratic, cubic, b-spline
    
    Contemplating how to do spline controller
    DragonMoffon committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    eafa68c View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. Removed splines from this PR

    Removed Splines
    Made Isometric Controller
    Fixed small issue with facing direction
    doing temp rendering test so don't mind `log.png`
    DragonMoffon committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    8818c22 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. Configuration menu
    Copy the full SHA
    0d877a5 View commit details
    Browse the repository at this point in the history
  2. General work

    DragonMoffon committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    4a70234 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7e1659f View commit details
    Browse the repository at this point in the history
  4. Cleaned up Offscreen renderer

    Added 'nother default glsl shader. Also cleaned up some linting.
    DragonMoffon committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    c946cc9 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. Configuration menu
    Copy the full SHA
    8daf88b View commit details
    Browse the repository at this point in the history
  2. Squashed commit of the following:

    commit 7d56d39
    Author: DragonMoffon <happydog.aja@gmail.com>
    Date:   Fri Aug 18 05:16:55 2023 +1200
    
        Created a camera shake class
    
        Created a camera shake class. It isn't exactly like the shake provided before so people might what to have a review.
    DragonMoffon committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    27066e0 View commit details
    Browse the repository at this point in the history
  3. added screen shake doc

    DragonMoffon committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    4d19763 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2023

  1. lovely useless doc strings

    NOTE: The doc strings aren't useless. The code just is. Going to completely change the class.
    DragonMoffon committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    d117572 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2023

  1. improving screen shake

    DragonMoffon committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    f94eed4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    166cae3 View commit details
    Browse the repository at this point in the history