Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example for positioning flat buttons to docs #2026

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

lbcai
Copy link
Contributor

@lbcai lbcai commented Mar 16, 2024

Fixes #1127

@pushfoo
Copy link
Member

pushfoo commented Mar 17, 2024

TL;DR: I want to rephrase this but need more time to think. Also, the original page is broken from a UX / readability perspective.

I'm currently in favor of keeping your changes, but in a rephrased form. I need more time to think about the best way because the original page original page is just kind of broken.

The problem with the page you're trying to improve is:

  1. We say "don't do X"
  2. We then do the exact opposite

For beginners who just want to add UI, this is overwhelming. Three separate code versions would be better, but the example gallery is already crowded.

The third option is to investigate unifying examples into single pages with tab plugins, and there's a discord thread about that in the doc improvement channel. However. there's work that Clepto or I need to do first:

  1. Fix the readthedocs build
  2. Either:
    • Verify that PDF output still works with one of the known Furo-compatible tab plugins
    • Come up with a workaround for the PDF build

@eruvanos
Copy link
Member

@pushfoo
Should we take the changes, I like the additional explanations.

The other issues you mention are valid, independent of these additions, right?

Copy link
Member

@pushfoo pushfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TL;DR: Let's merge it as-is.

We'll be giving these examples another look anyway. Since @sabadam32's findings suggest tab plugins should work for these example pages, this might get moved and rephrased to a tab.

@eruvanos eruvanos merged commit 6fdf5c5 into pythonarcade:development Mar 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update example for flat text buttons
3 participants