Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix homepage css #2027

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Fix homepage css #2027

merged 2 commits into from
Mar 28, 2024

Conversation

lbcai
Copy link
Contributor

@lbcai lbcai commented Mar 16, 2024

Fixes #2023

  • Adjusted the top header where the sprinter and the star button are
  • Made the Contributing section always have 1 column since there are only 2 items there. But if 2 columns are preferred, I'll change that back
  • Added a little margin between sections
  • Made Social and Learning Resources section swap to 1 column if screen is small enough, just like the other sections
  • Adjusted star button for dark mode users. Before:
    image
    After:
    image
    It's not currently possible to make the iframe background match the color of the dark mode docs. To fix that, we could use this other solution (https://buttons.github.io/) that involves loading a Javascript script, but it seems like this background issue is only present in Firefox and not in Chrome so I imagine it's low priority.

Copy link
Member

@pushfoo pushfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TL;DR: Is it possible to split the GitHub stars fix into a separate, smaller PR to merge it in faster?

Visually, this definitely seems to work and I like it. However:

  • We're mixing multiple concerns right now
  • Adding some clarification comments might help us in the future
  • Some of the CSS class names are a little vague, but that might be OK with comments

doc/_static/css/custom.css Outdated Show resolved Hide resolved
doc/_static/css/custom.css Outdated Show resolved Hide resolved
@pvcraven
Copy link
Member

pvcraven commented Mar 27, 2024

The PR makes things better. Bit more code churn than I'd like.

Looking at it, I think that whole toc-outside-links can be removed. It was originally created when I didn't know how to do links (or was it supported at that point?) in a TOC, so I faked one.

See: this other PR

Think this PR should be merged, then go back and simplify.

@pvcraven pvcraven merged commit f3d931b into pythonarcade:development Mar 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation Issue: Contributing section on home page has alignment issues
3 participants