-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: relative position helpers #2051
Open
DigiDuncan
wants to merge
6
commits into
pythonarcade:development
Choose a base branch
from
DigiDuncan:relative_positions
base: development
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e970a5f
relative position helpers
DigiDuncan bef4bce
fix docstring
DigiDuncan 48b8600
Clean up docstrings of relative window position helpers
pushfoo 8f19679
Clean up naming and style a bit
pushfoo 5674046
Merge pull request #4 from pushfoo/relative_positions
DigiDuncan 250a631
fix math error
DigiDuncan File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -915,6 +915,30 @@ def on_mouse_leave(self, x: int, y: int): | |
""" | ||
pass | ||
|
||
def absolute(self, fractional_pos: tuple[float, float]) -> tuple[float, float]: | ||
"""Convert a relative fractional pair to absolute screen pixels. | ||
|
||
As in the rest of arcade and OpenGL, the default coordinate system | ||
places the origin at the bottom left. | ||
|
||
:param fractional_pos: A position where the x and y are fractional | ||
values of the window size. | ||
:returns: A tuple of absolute pixel X and Y relative to bottom left. | ||
""" | ||
w, h = self.size | ||
frac_x, frac_y = fractional_pos | ||
return frac_x * w, frac_y * h | ||
|
||
def relative(self, pixel_pos: tuple[float, float]) -> tuple[float, float]: | ||
"""Convert absolute screen pixels to a relative fractional pair. | ||
|
||
:param pixel_pos: a tuple of X and Y pixel positions within the window. | ||
:returns: A tuple of fractional X and Y relative to the bottom left. | ||
Comment on lines
+932
to
+936
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This docstring just seems to academic and lacks contex/example. It's unclear what "fractional pair" is. Also unsure is the method name itself is clear. |
||
""" | ||
w, h = self.size | ||
pixel_x, pixel_y = pixel_pos | ||
return pixel_x / w, pixel_y / pixel_y | ||
DigiDuncan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
|
||
def open_window( | ||
width: int, | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This docstring just seems to academic and lacks contex/example. It's unclear what "fractional pair" is. Also unsure is the method name itself is clear.