Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port away from should_be #215

Closed
frozencemetery opened this issue Jul 7, 2020 · 2 comments
Closed

Port away from should_be #215

frozencemetery opened this issue Jul 7, 2020 · 2 comments
Assignees
@stanislavlevin
Labels
test

Comments

@frozencemetery
Copy link
Member

should_be doesn't work with python-3.8 and it's unmaintained, so we need something else before fc31 testing stops being viable.
frozencemetery added a commit that referenced this issue Jul 7, 2020
@frozencemetery
[ci] Hold back Fedora version for should-be
274886c 
See also #215
This was referenced Jul 7, 2020
Closed
Closed
@stanislavlevin
Copy link
Contributor

Hi, @frozencemetery. Some time ago I filed the identical issue #130. Since that time I build python-gssapi for my distro without should_be. If somebody interests I could open related PR.

@frozencemetery
Copy link
Member Author

Unless I'm missing something, #130 is for something different: our test suite works just fine up through 3.7 as far as I can tell. (Certainly it works on fedora 31, which is python3-3.7.8-1.fc31, so...)

I am of course happy to consider pull requests to address this issue :) Please do submit them in the form of pull requests (and not attached .patch files).

stanislavlevin added a commit to stanislavlevin/python-gssapi that referenced this issue Jul 10, 2020
@stanislavlevin
tests: Drop dependency on python-should_be
daa47ac 
Change should_be assertions to unittest(stdlib) ones.
should_be is unmaintained and doesn't work against Python3.8.

Fixes: pythongssapi#215
stanislavlevin added a commit to stanislavlevin/python-gssapi that referenced this issue Jul 10, 2020
@stanislavlevin
tests: Drop dependency on python-should_be
af11f66 
Change should_be assertions to unittest(stdlib) ones.
should_be is unmaintained and doesn't work against Python3.8.

Fixes: pythongssapi#215
stanislavlevin added a commit to stanislavlevin/python-gssapi that referenced this issue Jul 10, 2020
@stanislavlevin
tests: Drop dependency on python-should_be
f2576d2 
Migrate should_be assertions to unittest(stdlib) ones.
This requires Python3.2+.

Fixes: pythongssapi#215
Signed-off-by: Stanislav Levin <slev@altlinux.org>
@stanislavlevin stanislavlevin mentioned this issue Jul 10, 2020
Closed
@jonringer jonringer mentioned this issue Sep 20, 2020
Merged
10 tasks
frozencemetery pushed a commit to frozencemetery/python-gssapi that referenced this issue Nov 12, 2020
@stanislavlevin @frozencemetery
Drop test dependency on should_be
1a739d9 
Fixes: pythongssapi#215
Merges: pythongssapi#219

Signed-off-by: Stanislav Levin <slev@altlinux.org>
Signed-off-by: Robbie Harwood <rharwood@redhat.com>

[rharwood@redhat.com: bugfixes, rebase around six changes, not abusing
Python equating empty and False, misc additional test cleanups, commit
message]
frozencemetery pushed a commit to frozencemetery/python-gssapi that referenced this issue Nov 12, 2020
@stanislavlevin @frozencemetery
Drop test dependency on should_be
a05f131 
Fixes: pythongssapi#215
Merges: pythongssapi#219

Signed-off-by: Stanislav Levin <slev@altlinux.org>
Signed-off-by: Robbie Harwood <rharwood@redhat.com>

[rharwood@redhat.com: bugfixes, rebase around six changes, not abusing
Python equating empty and False, misc additional test cleanups, commit
message]
@frozencemetery frozencemetery mentioned this issue Nov 12, 2020
Merged
frozencemetery pushed a commit to frozencemetery/python-gssapi that referenced this issue Nov 12, 2020
@stanislavlevin @frozencemetery
Drop test dependency on should_be
5d87a94 
Fixes: pythongssapi#215
Merges: pythongssapi#219

Signed-off-by: Stanislav Levin <slev@altlinux.org>
Signed-off-by: Robbie Harwood <rharwood@redhat.com>

[rharwood@redhat.com: bugfixes, rebase around six changes, not abusing
Python equating empty and False, misc additional test cleanups, commit
message]
frozencemetery pushed a commit to frozencemetery/python-gssapi that referenced this issue Nov 12, 2020
@stanislavlevin @frozencemetery
Drop test dependency on should_be
6bcd286 
Fixes: pythongssapi#215
Merges: pythongssapi#219

Signed-off-by: Stanislav Levin <slev@altlinux.org>
Signed-off-by: Robbie Harwood <rharwood@redhat.com>

[rharwood@redhat.com: bugfixes, rebase around six changes, not abusing
Python equating empty and False, misc additional test cleanups, commit
message]
frozencemetery pushed a commit to frozencemetery/python-gssapi that referenced this issue Nov 13, 2020
@stanislavlevin @frozencemetery
Drop test dependency on should_be
7d2ab77 
Fixes: pythongssapi#215
Merges: pythongssapi#219

Signed-off-by: Stanislav Levin <slev@altlinux.org>
Signed-off-by: Robbie Harwood <rharwood@redhat.com>

[rharwood@redhat.com: bugfixes, rebase around six changes, not abusing
Python equating empty and False, misc additional test cleanups, commit
message]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stanislavlevin stanislavlevin

Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests: Drop dependency on python-should_be stanislavlevin/python-gssapi
2 participants
@frozencemetery @stanislavlevin