Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ticket button with coming soon message on click #67

Merged
merged 3 commits into from
Apr 19, 2018

Conversation

ananyo2012
Copy link
Contributor

Addresses #61 . Added a faded Tickets button which open a modal with coming soon message on click.

Preview with changes : https://ananyo2012.github.io/inpycon2018/

Copy link
Member

@realslimshanky realslimshanky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a suggestion. Adding coming soon would be more informative. Can be added as a subtext just below Buy Tickets.

Remove Modal and add Coming soon message
@ananyo2012
Copy link
Contributor Author

ananyo2012 commented Apr 19, 2018

I removed the modal and added Coming Soon text in both CFP and ticket buttons. Here is the screenshot of the page. @pythonindia/pycon-2018-team Please review this

screenshot from 2018-04-20 00-01-54

Copy link
Member

@realslimshanky realslimshanky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to ship!

@realslimshanky realslimshanky merged commit 0d832e2 into pythonindia:master Apr 19, 2018
@ananyo2012 ananyo2012 deleted the gh-pages branch April 19, 2018 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants