-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix content alignment for mobile devices #78
Conversation
@daemon1024 Thank you for your contribution! 🎉 Since you are at it, can you also have a look at the footer? The above screenshot is taken at 553x812 resolution. |
@palnabarun Would this be the desired footer for devices with width < 768 ( currently set for width < 512 )? |
I was more worried about the alignment at that width ranges. In an ideal world, the flow should be like:
Now, the screen widths at which the transition between 1, 2 and 3 have to be done can be decided independently. PS: The stop can be changed to a bit higher too. |
@palnabarun handled the 3 cases from what i interpretted. I didnt change the stops since they seemed fine to me. The above screenshot is taken at 553x812 resolution. |
@daemon1024 Awesome! The transition looks neat now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am approving this PR for now. But, will wait for others to take a look at the changes and comment if needed.
Thanks again for your contribution!
@palnabarun Great! |
The design team gave the design for the footer today morning. https://www.figma.com/file/l3fowoKJ1OAyXRd7j095r5/PyconIND-Assets?node-id=815%3A0. The gradient has to go away and the items have to be stacked. The idea of the scroll was to denote the end of the scroll. |
Got it. Will remove that.
In the design file i only see design for mobile and ipad, do you want it to be the stacked for desktop too or I should leave that. Also the iPad design is contradicting with what @palnabarun suggested in
This is what i updated in last commit so I will revert it and make it column stacked all the way if you say so.
I didn't get what do you mean by scroll here. |
fix the sponsorship prospectus download button fix logo and header for mobile devices fix footer for medium width alter footer gradient
No description provided.