Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix content alignment for mobile devices #78

Merged
merged 1 commit into from
Sep 4, 2020
Merged

Fix content alignment for mobile devices #78

merged 1 commit into from
Sep 4, 2020

Conversation

daemon1024
Copy link
Contributor

No description provided.

@palnabarun
Copy link
Member

@daemon1024 Thank you for your contribution! 🎉

Since you are at it, can you also have a look at the footer?

image

The above screenshot is taken at 553x812 resolution.

@daemon1024
Copy link
Contributor Author

@palnabarun Would this be the desired footer for devices with width < 768 ( currently set for width < 512 )?

image

@palnabarun
Copy link
Member

palnabarun commented Aug 29, 2020

I was more worried about the alignment at that width ranges.

In an ideal world, the flow should be like:

  1. If all 3 divs can be accommodated in the same row, do that.
  2. If all but the last div can be accommodated in the same row, drop the social icon div to next row and make all the divs centered like:
 LOGO <-> COPYRIGHT
<-> SOCIAL ICONS <->
  1. If only one div can be accommodated in a single row, push all three to separate rows and make them center aligned.

Now, the screen widths at which the transition between 1, 2 and 3 have to be done can be decided independently.

PS: The stop can be changed to a bit higher too.

@daemon1024
Copy link
Contributor Author

daemon1024 commented Aug 29, 2020

@palnabarun handled the 3 cases from what i interpretted. I didnt change the stops since they seemed fine to me.

image

The above screenshot is taken at 553x812 resolution.

@palnabarun
Copy link
Member

@daemon1024 Awesome! The transition looks neat now.

Copy link
Member

@palnabarun palnabarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving this PR for now. But, will wait for others to take a look at the changes and comment if needed.

Thanks again for your contribution!

@daemon1024
Copy link
Contributor Author

@palnabarun Great!

@sayanchowdhury
Copy link
Member

The design team gave the design for the footer today morning. https://www.figma.com/file/l3fowoKJ1OAyXRd7j095r5/PyconIND-Assets?node-id=815%3A0.

The gradient has to go away and the items have to be stacked. The idea of the scroll was to denote the end of the scroll.

@daemon1024
Copy link
Contributor Author

daemon1024 commented Aug 29, 2020

@sayanchowdhury

The gradient has to go away

Got it. Will remove that.

and the items have to be stacked.

In the design file i only see design for mobile and ipad, do you want it to be the stacked for desktop too or I should leave that. Also the iPad design is contradicting with what @palnabarun suggested in

  1. If all but the last div can be accommodated in the same row, drop the social icon div to next row and make all the divs centered like:
 LOGO <-> COPYRIGHT
<-> SOCIAL ICONS <->

This is what i updated in last commit so I will revert it and make it column stacked all the way if you say so.

The idea of the scroll was to denote the end of the scroll.

I didn't get what do you mean by scroll here.

fix the sponsorship prospectus download button

fix logo and header for mobile devices

fix footer for medium width

alter footer gradient
@palnabarun palnabarun merged commit 2dfa728 into pythonindia:master Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants