#364 Added Models for Users Profile. #469

RishabhJain2018 · 2016-07-04T21:19:18Z

No description provided.

kracekumar · 2016-07-05T05:42:08Z

junction/profiles/models.py

+	city=models.CharField(max_length=100, blank=False, null=False)
+	contact_no = models.CharField(max_length=10, blank=False, null=False)
+
+	created = models.DateTimeField("Created", null=True, auto_now_add=True)


Look in base/models, there is already mix-in for this.

I did not get you properly ?? Please explain to me.

Don't add created/modified, there is already mixins for this. Have a look at junction/base/models.py. AuditModel.

yeah I got that. Thanks for guiding. :)

kracekumar · 2016-07-05T05:44:51Z

I can't find how user profile will be created, can you add that logic as well ?
You need to write test case.

RishabhJain2018 · 2016-07-05T21:16:25Z

I am on writing tests. I will send a PR soon.

RishabhJain2018 · 2016-07-06T18:49:45Z

I have written tests for django but I am getting one error . I am uploading it please see to it and guide me.

kracekumar · 2016-07-07T05:09:57Z

pip install -r requirements-dev.txt https://github.com/pythonindia/junction/blob/master/requirements-dev.txt

RishabhJain2018 · 2016-07-07T05:24:26Z

@kracekumar I tried the command you mentioned above, but it is giving me some unexpected error. I also googled it but could not find anything relevant. Please look into it as I am putting the screenshot.

ChillarAnand · 2016-07-07T14:54:45Z

Have you modified requirements.txt or requirements-dev.txt? Make sure there are no syntax errors in those files.

RishabhJain2018 · 2016-07-08T12:14:53Z

@ChillarAnand No, I haven't modified any of these files. Well I am running the junction module without docker. Is it because of that ?
please check these files , it gives error when a new user is installing. I have kept the screenshot of error above.

kracekumar · 2016-07-08T12:59:16Z

@RishabhJain2018 Can you paste the requirements file and can you merge master to your branch ?

RishabhJain2018 · 2016-07-08T13:10:37Z

@kracekumar yeah sure.

RishabhJain2018 · 2016-07-08T13:20:37Z

@kracekumar this is the requirements file & I have merged the master branch.

RishabhJain2018 · 2016-07-08T17:31:13Z

@kracekumar Please help.

kracekumar · 2016-07-08T18:18:35Z

Ok, I think you're using older version of pip. Upgrade the pip pip install -U pip and run the pip install -r requirements-dev.txt.

RishabhJain2018 · 2016-07-08T20:42:38Z

@kracekumar thanks for solving the issue. I upgraded my pip & it worked. I am again facing an error due to which my build is failing. please see to it.

kracekumar · 2016-07-08T22:17:10Z

@RishabhJain2018 Please attach screen shot only for UI changes, else pass on the link or paste the output. Exception says no such table: profiles_profile. You need to add migration file. Read here.

coveralls · 2016-07-09T10:01:29Z

Coverage increased (+0.07%) to 72.078% when pulling 0d2ff38 on RishabhJain2018:master into 6451feb on pythonindia:master.

RishabhJain2018 · 2016-07-09T10:05:59Z

@kracekumar Thanks for the guidance. :)

kracekumar · 2016-07-09T13:12:00Z

junction/profiles/admin.py

+
+
+class UserAdmin(admin.ModelAdmin):
+    list_display = ('__unicode__', 'city', 'contact_no')


Why is this __unicode__ required ?

This is to display user name in Profile admin. corresponding to whom the city and contact_no belongs.

Please remove __unicode__.

kracekumar · 2016-07-24T14:57:16Z

Before pushing the code, please rebase with the master branch.

coveralls · 2016-09-04T18:51:12Z

Coverage decreased (-0.1%) to 68.966% when pulling 6eede3a on RishabhJain2018:master into 9d244ed on pythonindia:master.

coveralls · 2016-09-09T19:03:24Z

Coverage decreased (-0.2%) to 68.839% when pulling 72e8f75 on RishabhJain2018:master into faf9607 on pythonindia:master.

RishabhJain2018 · 2016-09-09T19:06:10Z

@kracekumar @theskumar I have made the changes as per the requirement. Please review it.

ChillarAnand · 2016-09-15T12:58:01Z

junction/profiles/views.py

+
+    elif request.method == "GET":
+        user = get_object_or_404(User, pk=username.id)
+        detail = get_object_or_404(Profile, user=user)


Shouldn't we create a profile before this?

@ChillarAnand I didn't get you. Please explain in detail.

When a user visits edit page, it is simply throwing a 404 page. Shouldnt we create a profile before if it doesnt exists for that user?

@ChillarAnand okk

@ChillarAnand I have fixed the changes . Please see to it.

RishabhJain2018 · 2016-09-15T18:11:15Z

@ChillarAnand @kracekumar Please review the PR & tell me any other changes that needs to be done. 😃

coveralls · 2016-09-15T18:14:09Z

Coverage decreased (-0.2%) to 68.839% when pulling 5bf8175 on RishabhJain2018:master into faf9607 on pythonindia:master.

coveralls · 2016-09-17T19:28:08Z

Coverage decreased (-0.2%) to 68.839% when pulling 8db1f43 on RishabhJain2018:master into faf9607 on pythonindia:master.

coveralls · 2016-09-18T09:11:26Z

Coverage decreased (-0.6%) to 68.479% when pulling caafce3 on RishabhJain2018:master into faf9607 on pythonindia:master.

ChillarAnand · 2016-09-18T15:18:29Z

junction/profiles/admin.py

+
+
+class ProfileAdmin(admin.ModelAdmin):
+    list_display = ('__unicode__', 'city', 'contact_no')


Can you use user instead of unicode?

yeah sure. but can you explain me why user is better?

ChillarAnand · 2016-09-18T15:24:57Z

@RishabhJain2018 Looks good. There are several migrations. Remove all files from migrations folder except __init__.py and run makemigrations & migrate, it should squash them to one.

coveralls · 2016-09-18T16:34:11Z

Coverage decreased (-0.6%) to 68.479% when pulling 7685efc on RishabhJain2018:master into faf9607 on pythonindia:master.

RishabhJain2018 · 2016-09-19T17:33:38Z

@ChillarAnand I have done the changes and also squashed the migrations.

ChillarAnand · 2016-09-20T18:17:24Z

Excellent. Thank you @RishabhJain2018

kracekumar · 2017-02-11T17:57:18Z

junction/profiles/views.py

+
+@login_required
+def profile(request):
+    username = request.user


Can you rename the variable to user?

kracekumar · 2017-02-11T17:57:56Z

junction/profiles/views.py

+    username = request.user
+    detail = None
+
+    if request.method == "POST" and username == request.user:


Can I know why is the check username == request.user required?

Added Models for Users Profile

5ecccfe

kracekumar reviewed Jul 5, 2016
View reviewed changes

RishabhJain2018 added 3 commits July 6, 2016 18:39

Removed Errors & tests written

e20375e

Travis build check

5cf2581

Travis CI fixes

7b09d60

Merge remote-tracking branch 'upstream/master'

91e1f4c

RishabhJain2018 added 2 commits July 9, 2016 01:58

Merge remote-tracking branch 'upstream/master'

dd38ee6

Tests written and Models created

1ae6e0a

Added Migrations file

0d2ff38

kracekumar reviewed Jul 9, 2016
View reviewed changes

merging upstream

6eede3a

RishabhJain2018 added 5 commits September 5, 2016 02:15

Taking data using Model Form Django

e7f0e8d

Added profile view with update feature.

2affb32

Merge remote-tracking branch 'upstream/master'

65bdc0d

flake8 fixes

8463b41

flake8 fixes

72e8f75

ChillarAnand requested changes Sep 15, 2016

View reviewed changes

RishabhJain2018 added 2 commits September 15, 2016 23:35

Reverted Indendation

118477e

Removing Comments

5bf8175

Added Changes

8db1f43

RishabhJain2018 added 2 commits September 18, 2016 13:13

Added Views for user Profile

651c368

flake8 fixes

caafce3

ChillarAnand requested changes Sep 18, 2016

View reviewed changes

Changes done and migrations squashed

7685efc

ChillarAnand merged commit d92a645 into pythonindia:master Sep 20, 2016

RishabhJain2018 mentioned this pull request Feb 11, 2017

Add user profile #364

Closed

kracekumar reviewed Feb 11, 2017

View reviewed changes

junction/profiles/views.py

@login_required

def profile(request):

username = request.user

Copy link

Member

kracekumar Feb 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rename the variable to user?

kracekumar reviewed Feb 11, 2017

View reviewed changes



		class UserAdmin(admin.ModelAdmin):
		list_display = ('__unicode__', 'city', 'contact_no')



		class ProfileAdmin(admin.ModelAdmin):
		list_display = ('__unicode__', 'city', 'contact_no')

#364 Added Models for Users Profile. #469

#364 Added Models for Users Profile. #469

Conversation

RishabhJain2018 commented Jul 4, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kracekumar commented Jul 5, 2016

RishabhJain2018 commented Jul 5, 2016

RishabhJain2018 commented Jul 6, 2016

kracekumar commented Jul 7, 2016

RishabhJain2018 commented Jul 7, 2016

ChillarAnand commented Jul 7, 2016

RishabhJain2018 commented Jul 8, 2016

kracekumar commented Jul 8, 2016

RishabhJain2018 commented Jul 8, 2016

RishabhJain2018 commented Jul 8, 2016 • edited Loading

RishabhJain2018 commented Jul 8, 2016 • edited Loading

kracekumar commented Jul 8, 2016

RishabhJain2018 commented Jul 8, 2016

kracekumar commented Jul 8, 2016

coveralls commented Jul 9, 2016 • edited Loading

RishabhJain2018 commented Jul 9, 2016

kracekumar Jul 9, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kracekumar commented Jul 24, 2016

coveralls commented Sep 4, 2016 • edited Loading

coveralls commented Sep 9, 2016 • edited Loading

RishabhJain2018 commented Sep 9, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RishabhJain2018 Sep 17, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RishabhJain2018 commented Sep 15, 2016 • edited Loading

coveralls commented Sep 15, 2016 • edited Loading

coveralls commented Sep 17, 2016 • edited Loading

coveralls commented Sep 18, 2016 • edited Loading

Choose a reason for hiding this comment

RishabhJain2018 Sep 18, 2016 • edited Loading

Choose a reason for hiding this comment

ChillarAnand commented Sep 18, 2016

coveralls commented Sep 18, 2016 • edited Loading

RishabhJain2018 commented Sep 19, 2016

ChillarAnand commented Sep 20, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RishabhJain2018 commented Jul 8, 2016 •

edited

Loading

RishabhJain2018 commented Jul 8, 2016 •

edited

Loading

coveralls commented Jul 9, 2016 •

edited

Loading

kracekumar Jul 9, 2016 •

edited

Loading

coveralls commented Sep 4, 2016 •

edited

Loading

coveralls commented Sep 9, 2016 •

edited

Loading

RishabhJain2018 commented Sep 9, 2016 •

edited

Loading

RishabhJain2018 Sep 17, 2016 •

edited

Loading

RishabhJain2018 commented Sep 15, 2016 •

edited

Loading

coveralls commented Sep 15, 2016 •

edited

Loading

coveralls commented Sep 17, 2016 •

edited

Loading

coveralls commented Sep 18, 2016 •

edited

Loading

RishabhJain2018 Sep 18, 2016 •

edited

Loading

coveralls commented Sep 18, 2016 •

edited

Loading