Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloud_engineer_crowdstrike.html #327

Merged
merged 7 commits into from
Apr 25, 2018
Merged

Conversation

marieana
Copy link
Contributor

No description provided.

@hartwork
Copy link
Contributor

There are many things/details wrong with this pull request (filename, creation date, tags, ..); please:

  • turn cloud engineer_crowdstrike into cloud_engineer_crowdstrike.html: with extension and without space
  • drop the # Choose one of the following options
  • add a space after comma in location: Bucharest,Romania
  • update the creation timestamp, 2015-02-20 looks off
  • ...

@marieana can you provide a follow-up version proving more care please?

@stestagg
Copy link
Contributor

Thanks Sebastian, yes, those issues are all relevant, unfortunately my update to auto-flag these issues as comments was foiled here by the file not being valid markdown, so the validator is failing too early.

@hartwork, I think Pythonjobs sits in an 'uncanny valley' here because a lot of the people submitting jobs less technical or non-developers so may not have the same level of experience, or comfort when dealing with making machine-parseable markdown.

@salimfadhley actually saw this as a 'feature' when he came up with the idea, as it does mean that we're naturally selecting for more technically minded submissions, and/or people who are willing to invest the time to learn.

In this case, it looks a bit like Ana joined github especially to make this posting, so I think it's as likely that the submission issues were caused by unfamiliarity with the tech/processes as much as a lack of care, it would be a shame to put people off from the site by assuming the opposite.

@marieana, sorry for hi-jacking your PR, is the role still open? If so, we can give a hand with getting this submission live? Thanks

@marieana
Copy link
Contributor Author

marieana commented Apr 23, 2018 via email

@marieana marieana changed the title Create cloud engineer_crowdstrike cloud_engineer_crowdstrike.html Apr 24, 2018
@stestagg
Copy link
Contributor

Hey @marieana - I think somewhere along the way, you copy-pasted the text from github which added in some extra '+' characters on each line.

I've removed these, and tweaked the '---' separators :)

@marieana
Copy link
Contributor Author

marieana commented Apr 24, 2018 via email

@pythonjobsbot
Copy link

We've run a few automated tests and discovered an issue:

cloud engineer_crowdstrike:

  • Job files must end with .html, not ``

If you'd like some help correcting this, or think the error is not valid, please reply to this comment.

name: Ana Robu
email: ana.robu@crowdstrike.com
--
+title:Senior Cloud Engineer with Python
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, it looks like you've indented every line of the file. That's completely unnecessary and will break the compiler!

Can you refer to the example text on our readme page?
https://github.com/pythonjobs/jobs

That shows you exactly how to format a job ad.

+- python
+- AWS
+- Go
+# Overview
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So just for example, the # should be the first char of this line.

@salimfadhley
Copy link
Contributor

@marieana - do you want to get me on Hangouts - salimfadhley@gmail.com - we can do a screen share and show you how it needs to work.

@stestagg stestagg reopened this Apr 25, 2018
@pythonjobs pythonjobs deleted a comment from pythonjobsbot Apr 25, 2018
@stestagg
Copy link
Contributor

Sorry if you've been spammed by emails, I've been sneakily testing some helpers to make submissions a bit easier using your PR, this is good to merge now :)

@pythonjobsbot
Copy link

Hi

Thanks for submitting this job advert.

Here are some screenshots of what the live listing should look like:

Job listing preview

Thanks

Pythonjobs

@stestagg stestagg merged commit 8d197e8 into pythonjobs:master Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants