Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.2.1 #321

Closed
9 tasks done
filmor opened this issue Jan 9, 2017 · 43 comments
Closed
9 tasks done

Release 2.2.1 #321

filmor opened this issue Jan 9, 2017 · 43 comments
Assignees

Comments

@filmor
Copy link
Member

filmor commented Jan 9, 2017

I guess it's general consensus (even though we have a v2.2.0 tag which is incompatible with our conda recipe) that we haven't released, yet, so I'd like to list up what's to do and to merge before we deem this done (and maybe we'll hold off merging new features until then):

@den-run-ai
Copy link
Contributor

I plan to work on release on Sunday

@vmuriart
Copy link
Contributor

vmuriart commented Jan 9, 2017

@filmor I don't see a tag for v2.2.0. The draft references the tag, but doesn't actually point to an existing one. Not sure if someone already deleted it but marking that first item out :)

@den-run-ai
Copy link
Contributor

den-run-ai commented Jan 9, 2017 via email

@vmuriart
Copy link
Contributor

vmuriart commented Jan 9, 2017

I'm not familiar with the issue since I work on windows. @denfromufa was that an issue introduced on or after v2.1.0?

@stonebig
Copy link
Contributor

release cut for Anaconda looks like tomorrow

@den-run-ai
Copy link
Contributor

@stonebig I'm able to access pythonnet on anaconda now. I plan to work on release tonight.

https://anaconda.org/pythonnet/pythonnet

@stonebig
Copy link
Contributor

tonight ?

@den-run-ai
Copy link
Contributor

den-run-ai commented Jan 21, 2017 via email

@den-run-ai
Copy link
Contributor

@filmor @vmuriart I removed this from v2.2.0 based on our discussion:

But I also added this:

  • Upload to testpypi and test

@vmuriart
Copy link
Contributor

I'm ok with merging #301 with exception of the last commit. If that one commit gets reverted it solves the original intent of #301 and closes #299. The last commit feels like an extra feature that may need more testing.

@vmuriart
Copy link
Contributor

good call on testpypi. Though I think @tonyroberts only gave you access to the pypi account.

@den-run-ai
Copy link
Contributor

@vmuriart I have access to both pypi from @tonyroberts and to testpypi from @davidanthoff
do you have pypi and testpypi accounts?

@den-run-ai
Copy link
Contributor

den-run-ai commented Jan 25, 2017

I'm ok with merging #301 with exception of the last commit. If that one commit gets reverted it solves the original intent of #301 and closes #299. The last commit feels like an extra feature that may need more testing.

@vmuriart but I think it should be like this: PySys_SetArgvEx(1, pylistargv, 0)

@vmuriart
Copy link
Contributor

@denfromufa yes on both pypi and testpypi.
ok, sounds like we'll be holding off on #301 then.

@stonebig
Copy link
Contributor

tonight ?

@vmuriart
Copy link
Contributor

The same thing we do every night, Pinky - try to take over the world!

Couldn't resist...
I'll work on closing out the README and CHANGELOG

@vmuriart
Copy link
Contributor

completed the changes, but the prior v2.2.0 release from November isn't letting me release against v2.2.0.

I'll bump everything to v2.2.1 instead and add a note on the changelog

@vmuriart
Copy link
Contributor

ehh on second though, I'd rather bump the version to 2.3.0 and treat 2.2.0-dev1 as the 2.2.0 release.

Thoughts? @filmor @denfromufa

@den-run-ai
Copy link
Contributor

den-run-ai commented Jan 27, 2017 via email

@vmuriart
Copy link
Contributor

Actually if we make v2.2.0 a commit between last release and now, then we would be rewriting history 😄
v2.2.1 is fine, it just didn't sound right when I wrote it in the CHANGELOG.

The test package is in testpypi.

@den-run-ai
Copy link
Contributor

den-run-ai commented Jan 27, 2017 via email

@vmuriart
Copy link
Contributor

I had a small mess up on the initial release to testpypi ... 😢. Since it won't let you re-upload the package its locked.

@den-run-ai
Copy link
Contributor

den-run-ai commented Jan 27, 2017 via email

@den-run-ai
Copy link
Contributor

den-run-ai commented Jan 27, 2017 via email

@den-run-ai
Copy link
Contributor

Everyone, FYI here is release to testpypi for testing:

https://testpypi.python.org/pypi/pythonnet/2.2.0

The tags on top are missing py3.6, still shows 2.2.0.dev1

@vmuriart
Copy link
Contributor

The tags get updated when its uploaded to pypi it gets it from the latest avaliable version in pypi.
Once the newer one is released, the tags get updated.

@vmuriart
Copy link
Contributor

Testpypi for 2.2.1

Appveyor installing from testpypi and version check

@vmuriart vmuriart changed the title Release 2.2.0 Release 2.2.1 Jan 27, 2017
@den-run-ai
Copy link
Contributor

@vmuriart for some reason (ana)conda package is still 2.2.0-dev1, let me try to resolve:

image

@den-run-ai
Copy link
Contributor

den-run-ai commented Jan 28, 2017

@vmuriart the conda package is looking at git tags, which I also updated:

https://github.com/pythonnet/pythonnet/releases/tag/v2.2.1

But this will now rebuild all packages, so may need to re-upload to testpypi (I guess except source distribution).

@vmuriart
Copy link
Contributor

vmuriart commented Jan 28, 2017 via email

@den-run-ai
Copy link
Contributor

@vmuriart @jreback please try out conda package from anaconda.org:

conda install -c pythonnet pythonnet=v2.2.1

https://anaconda.org/pythonnet/pythonnet

I could add @vmuriart to package managers, but not @filmor and @tonyroberts because they are already registered.

@den-run-ai
Copy link
Contributor

@stonebig do you have a chance to test out pythonnet from testpypi in winpython?

pip install -i https://testpypi.python.org/pypi pythonnet -U --force

@den-run-ai
Copy link
Contributor

nice checklist for the future versions:

https://gist.github.com/audreyr/5990987

@stonebig
Copy link
Contributor

stonebig commented Jan 28, 2017

@denfromufa pythonnet-2.2.0 is already shipped and uploaded.... re-doing a rc3.... bump winpython package version to cleanup my own numbering mess

@vmuriart
Copy link
Contributor

@stonebig we bumped the version number to v2.2.1

@vmuriart
Copy link
Contributor

@denfromufa ok to finalize release to pypi?

@den-run-ai
Copy link
Contributor

den-run-ai commented Jan 28, 2017 via email

@vmuriart
Copy link
Contributor

done

@den-run-ai
Copy link
Contributor

@vmuriart everything seems to be working fine, but on linux with python 3+ I'm getting this weird issue:

#336

@vmuriart
Copy link
Contributor

@denfromufa can you grant me repository creation rights on the github account? I want to create the dummy repository to check release under Pythonnet account but didn't have write access.

@den-run-ai
Copy link
Contributor

@vmuriart done!

@vmuriart
Copy link
Contributor

@denfromufa Thanks! one last thing... I tried checking my access on the Anaconda package. I got the email asking to confirm access to the package, but didn't grant me rights to it.

@den-run-ai
Copy link
Contributor

@vmuriart i sent a support request to Continuum folks, but their support is very limited for free accounts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants