added presets for mistral7b #63
Conversation
alvion427
commented
Dec 20, 2023
alvion427
commented
- option to specify name of model on command line
|
Hi @alvion427! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Could you remove the I'm happy to merge the mistral change. |
alvion427
force-pushed
the
mistral-support
branch
3 times, most recently
from
92579ce
to
31af07d
Compare
alvion427
force-pushed
the
mistral-support
branch
from
31af07d
to
81f1d06
Compare
|
cool, i finally got around to this!
…On Thu, Dec 21, 2023 at 3:36 AM Horace He ***@***.***> wrote:
Could you remove the model_name modification? Nothing against it in
particular, but since this repo doesn't have any CI set up and I'm
currently unable to test these repos - it's a bit hard to validate
correctness from only reviewing code PRs.
I'm happy to merge the mistral change.
—
Reply to this email directly, view it on GitHub
<#63 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQDRFGWMRUXQTEMIAGMS2DYKOVD7AVCNFSM6AAAAABA42KNVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRVGQZDQOBYGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Subscribed. would love to see this get merged! |
| @@ -56,6 +56,7 @@ def from_name(cls, name: str): | |||
| "30B": dict(n_layer=60, n_head=52, dim=6656), | |||
| "34B": dict(n_layer=48, n_head=64, dim=8192, vocab_size=32000, n_local_heads=8, intermediate_size=22016, rope_base=1000000), # CodeLlama-34B-Python-hf | |||
| "70B": dict(n_layer=80, n_head=64, dim=8192, n_local_heads=8, intermediate_size=28672), | |||
| "Mistral7B": dict(n_layer=32, n_head=32, n_local_heads=8, dim=4096, intermediate_size=14336, vocab_size=32002), | |||
There was a problem hiding this comment.
Hi @alvion427 , thanks for your PR.
I tried and need to change vocab_size=32000 to match the configs here.
