-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix errors in unbind and list slice #1088
Fix errors in unbind and list slice #1088
Conversation
Signed-off-by: Michael Feliz <michael.feliz@getcruise.com>
Hi @mfeliz-cruise! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mfeliz-cruise Can you please sign the CLA to merge? |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
@peri044 The CLA is now signed. |
@mfeliz-cruise Can you resolve the merge conflicts to merge ? |
Signed-off-by: Michael Feliz <michael.feliz@getcruise.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Michael Feliz michael.feliz@getcruise.com
Description
Handles negative axis in unbind and None values for start in slice operations on lists.
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: