Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: a bug in func run_test_compare_tensor_attributes_only #2809

Merged
merged 1 commit into from
May 3, 2024
Merged

fix: a bug in func run_test_compare_tensor_attributes_only #2809

merged 1 commit into from
May 3, 2024

Conversation

zewenli98
Copy link
Collaborator

Description

Fix a bug in func run_test_compare_tensor_attributes_only

Fixes #2808

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@zewenli98 zewenli98 self-assigned this May 3, 2024
@github-actions github-actions bot added the component: tests Issues re: Tests label May 3, 2024
@zewenli98 zewenli98 mentioned this pull request May 3, 2024
Merged
narendasan
narendasan approved these changes May 3, 2024
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@narendasan narendasan merged commit 4dc9acf into main May 3, 2024
54 of 58 checks passed
apbose pushed a commit that referenced this pull request May 24, 2024
@zewenli98 @apbose
fix: a bug in func run_test_compare_tensor_attributes_only (#2809)
ea790c0
laikhtewari pushed a commit that referenced this pull request May 24, 2024
@zewenli98 @laikhtewari
fix: a bug in func run_test_compare_tensor_attributes_only (#2809)
e9aa47a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan approved these changes

@peri044 peri044 Awaiting requested review from peri044

@apbose apbose Awaiting requested review from apbose

Assignees

@zewenli98 zewenli98

Labels
cla signed component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 [Bug] FAILED conversion\test_rand_aten.py
3 participants
@zewenli98 @narendasan @facebook-github-bot