Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

normalized argument in griffinlim is not used #1007

Closed
mthrok opened this issue Nov 5, 2020 · 3 comments 路 Fixed by #1036
Closed

normalized argument in griffinlim is not used #1007

mthrok opened this issue Nov 5, 2020 · 3 comments 路 Fixed by #1036

Comments

@mthrok
Copy link
Collaborator

mthrok commented Nov 5, 2020

馃悰 Bug

F.griffinlim's normalized func arg is not used. It should be removed or used.
If removing it, it should also be removed from T.GriffinLim.

@vincentqb
Copy link
Contributor

I'd suggest we add a warning if it is changed from the default value, and we can remove it in a subsequent version.

@krishnakalyan3
Copy link
Contributor

krishnakalyan3 commented Nov 13, 2020

I would like to work on this. Would something like the below be okay?

if normalized:
warnings.warn("griffinlim normalized arg is not used. This will be removed in v0.8.0 release")

Added here

@vincentqb
Copy link
Contributor

We should give one release of warning. We've just released 0.7, so this message will be visible in 0.8. We can then remove in 0.9 :)

Let's put the warning at the beginning of the function call, here. And we should also provide instructions on how to suppress the warning. I suggest something like this:

if normalized:
    warnings.warn("The argument normalized is not used in Griffin-Lim, and will be removed in v0.9.0 release. To suppress this warning, please use `normalized=False`.")

Please feel free to open a pull request for this, thanks! :)

mthrok pushed a commit to mthrok/audio that referenced this issue Dec 13, 2022
* Update torchvision_tutorial.rst

* Update torchvision_tutorial.rst

Co-authored-by: holly1238 <77758406+holly1238@users.noreply.github.com>
mpc001 pushed a commit to mpc001/audio that referenced this issue Aug 4, 2023
* test ghstack

[ghstack-poisoned]

* Update base for Update on "[PT-D] Add an example for Megatron-LM style example"




[ghstack-poisoned]

* Update base for Update on "[PT-D] Add an example for Megatron-LM style example"




[ghstack-poisoned]

* Update base for Update on "[PT-D] Add an example for Megatron-LM style example"




[ghstack-poisoned]

* Update base for Update on "[PT-D] Add an example for Megatron-LM style example"




[ghstack-poisoned]

* [PT-D] Add an example for Megatron-LM style example (pytorch#1006)

* [PT-D] Add an example for Megatron-LM style example

[ghstack-poisoned]

* Update on "[PT-D] Add an example for Megatron-LM style example"




[ghstack-poisoned]
mpc001 pushed a commit to mpc001/audio that referenced this issue Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants