[D] Update spectrogram to use complex #1009
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anjali411
reviewed
Nov 5, 2020
anjali411
reviewed
Nov 5, 2020
|
Do you have a suggestion for the tests to be added with respect to the complex dtype? |
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Nov 6, 2020
anjali411
reviewed
Nov 6, 2020
mthrok
force-pushed
the
migrate-spectrogram
branch
from
3d3229b
to
81a980f
Compare
vincentqb
reviewed
Nov 10, 2020
mthrok
force-pushed
the
migrate-spectrogram
branch
from
81a980f
to
478d613
Compare
mthrok
force-pushed
the
migrate-spectrogram
branch
3 times, most recently
from
e50c0b9
to
21e9316
Compare
21 tasks
mthrok
force-pushed
the
migrate-spectrogram
branch
from
21e9316
to
c0be0ca
Compare
3 tasks
mpc001
pushed a commit
to mpc001/audio
that referenced
this pull request
Aug 4, 2023
This reverts commit 9ba53df.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for getting signal on complex tensor adaptation, similar to #864
The internal changes should go into #1013, as it resolves the issue with backward pass of the Spectrogram. Then this PR will be about adding
return_complexarguments for the migration.