Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

torch.stft calls need to be updated to set the return_complex kwarg #1095

Closed
mruberry opened this issue Dec 17, 2020 · 0 comments · Fixed by #1096
Closed

torch.stft calls need to be updated to set the return_complex kwarg #1095

mruberry opened this issue Dec 17, 2020 · 0 comments · Fixed by #1096

Comments

@mruberry
Copy link
Contributor

torch.stft (https://pytorch.org/docs/master/generated/torch.stft.html?highlight=stft#torch.stft) has deprecated not setting the return_complex kwarg, and we want to make passing return_complex required before the PyTorch 1.8 release. To avoid torchaudio breaking with PyTorch nightlies or PyTorch 1.8 it needs to update its torch.stft calls to pass the return_complex argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant