-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update calls to torch.stft to have return_complex=True #1096
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @mthrok!
Since the plan is to deprecate |
That's a good future proofing idea, @peterbell10, but I suggest we just go with the simpler and smaller change for the moment and revisit how torchaudio wants to handle complex numbers for the 1.9 release. Maybe torchaudio will want to switch to using complex tensors. |
Not sure I understand. |
Oh you're right, thank you. I forgot we're also putting a warning on this. It's been a long day... Sorry @mthrok, I was mistaken. We should take @peterbell10's recommendation to use |
@peterbell10 @mruberry Update the PR to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Thank you again @mthrok and @peterbell10!
Resolves #1095