Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated function argument #1367

Closed
mthrok opened this issue Mar 6, 2021 · 0 comments · Fixed by #1369
Closed

Remove deprecated function argument #1367

mthrok opened this issue Mar 6, 2021 · 0 comments · Fixed by #1369

Comments

@mthrok
Copy link
Collaborator

mthrok commented Mar 6, 2021

In #1036, we have deprecated the argument which was introduced by an accident in the first place. Now we have finished with 0.8.0 release and master branch points to 0.9.0. We can remove the argument itself.

Steps

  1. Remove normalized from the function signature, docstring.
  2. Remove the deprecation warning

Testing

For the build process, please refer to the CONTRIBUTING.md.

The following tests should pass before and after the change..

python setup.py develop && ( cd test && pytest torchaudio_unittest/functional -vk griff)

cc @krishnakalyan3 if you are interested in

mthrok pushed a commit to mthrok/audio that referenced this issue Dec 13, 2022
Co-authored-by: holly1238 <77758406+holly1238@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant