Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-Breaking: Remove deprecated normalized argument from griffinlim #1369

Merged
merged 9 commits into from Mar 8, 2021
Merged

BC-Breaking: Remove deprecated normalized argument from griffinlim #1369

merged 9 commits into from Mar 8, 2021

Conversation

krishnakalyan3
Copy link
Contributor

Fixes #1367

@krishnakalyan3 krishnakalyan3 marked this pull request as draft March 7, 2021 11:29
@mthrok mthrok changed the title Remove normalized argument griffinlim BC-Breaking: Remove deprecated normalized argument from griffinlim Mar 7, 2021
mthrok
mthrok approved these changes Mar 7, 2021
View reviewed changes
Copy link
Collaborator

@mthrok mthrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@krishnakalyan3 krishnakalyan3 marked this pull request as ready for review March 7, 2021 19:55
@krishnakalyan3
Copy link
Contributor Author

@mthrok thanks for the review,

@mthrok mthrok merged commit 6d5e879 into pytorch:master Mar 8, 2021
@mthrok
Copy link
Collaborator

mthrok commented Mar 8, 2021

Thanks!

@krishnakalyan3 krishnakalyan3 deleted the griffinlim_rem branch March 8, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mthrok mthrok mthrok approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove deprecated function argument
3 participants
@krishnakalyan3 @mthrok @facebook-github-bot