-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making test code device aware. #515
Comments
|
The choice of CI is adjacent and we should discuss down the road. (though I have no objection to the migration to CircleCI) The followings are what I think needs to be sorted out for the next steps. (here I consider only CPU and CUDA for device option.)
|
#520 is my initial attempt to make CPU/GPU distinguish clear and parameterize device for a set of tests. |
Currently, test code does not have a standard way to handle device, which led to CUDA tests added disorganized ways, such as 1, 2 and 3.
Also it is worth noting that Travis CI is not running any of CUDA test. See here, search for
test_lfilter_cuda
.We should have a standard way to add CUDA test.
FYI: PyTorch has a mechanism to instantiate test class for different devices at runtime.
The text was updated successfully, but these errors were encountered: