Separate CPU and GPU tests for functions torchscript test + Fix devices in two functionals #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentqb
suggested changes
Apr 9, 2020
|
That test only failed on PY3.6 and it succeeded after re-run, meaning that the test is flaky. The proper fix will be to set random seed in |
vincentqb
approved these changes
Apr 9, 2020
| f_max = 20.0 | ||
| n_mels = 10 | ||
| sample_rate = 16000 | ||
| if self.device != torch.device('cpu'): |
There was a problem hiding this comment.
nit: It would have been nice to have a decorator like @onlyCPU that checks this.
| n_mfcc = 40 | ||
| n_mels = 128 | ||
| norm = "ortho" | ||
| if self.device != torch.device('cpu'): |
vincentqb
changed the title
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Apr 10, 2020
This lfilter tests were moved to `test_torchscript_consistency.py` in pytorch#507 and GPU tests were added in pytorch#528. We can safely remove this tests from `test_functional_filtering.py`.
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Apr 10, 2020
This lfilter tests were moved to `test_torchscript_consistency.py` in pytorch#507 and GPU tests were added in pytorch#528. We can safely remove this tests from `test_functional_filtering.py`.
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Apr 13, 2020
This lfilter tests were moved to `test_torchscript_consistency.py` in pytorch#507 and GPU tests were added in pytorch#528. We can safely remove this tests from `test_functional_filtering.py`.
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Apr 13, 2020
This lfilter tests were moved to `test_torchscript_consistency.py` in pytorch#507 and GPU tests were added in pytorch#528. We can safely remove this tests from `test_functional_filtering.py`.
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Apr 14, 2020
This lfilter tests were moved to `test_torchscript_consistency.py` in pytorch#507 and GPU tests were added in pytorch#528. We can safely remove this tests from `test_functional_filtering.py`.
vincentqb
pushed a commit
that referenced
this pull request
Apr 14, 2020
mthrok
pushed a commit
to mthrok/audio
that referenced
this pull request
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #520 this PR make
functionalmodule device awarefunctionalmodule found in Step 2.Relates to #515