Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refactor librosa compatibility test #1259

Merged
merged 3 commits into from Feb 21, 2021
Merged

feat: refactor librosa compatibility test #1259

merged 3 commits into from Feb 21, 2021

Conversation

AzizCode92
Copy link
Contributor

@AzizCode92 AzizCode92 commented Feb 11, 2021 •
edited

mthrok
mthrok reviewed Feb 18, 2021
View reviewed changes
Copy link
Collaborator

@mthrok mthrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AzizCode92

We can proceed with your PR. Can you resolve the conflict? I think #1267 caused the conflict.

@AzizCode92
Copy link
Contributor Author

Hi @mthrok,
I will work on this this week-end.
I will let you know once I am done.

thanks

mthrok
mthrok approved these changes Feb 21, 2021
View reviewed changes
Copy link
Collaborator

@mthrok mthrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mthrok mthrok merged commit bec9047 into pytorch:master Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mthrok mthrok mthrok approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AzizCode92 @mthrok @facebook-github-bot