Skip to content

Refactor librosa compatibility test #1255

@mthrok

Description

@mthrok

The number of unit tests we have in torchaudio has grown a lot. It is critical to keep tests organized so as to make it easy for contributors to write tests for the feature they are working on.

librosa consistency tests are for checking that torchaudio's implementations (functional/transform) are numerically comparable against the librosa's implementation.

The list of functional has grown, so we now have a dedicated test submodule for functional. We would like to move librosa consistency tests for functionals to this module.

Steps

  1. Create a librosa_compatibility_test.py in test/torchaudio_unittest/functional
  2. Move the TestFunctional and TestPhaseVocoder to the new script. (fix import and stuff)

Building and testing

Please refer to CONTRIBUTING for build process. You can check that the tests success with

(cd test && pytest torchaudio_unittest/functional/librosa_compatibility_test.py torchaudio_unittest/librosa_compatibility_test.py)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions