-
Notifications
You must be signed in to change notification settings - Fork 633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply functional batch consistency tests to batches of different items #1315
Merged
mthrok
merged 15 commits into
pytorch:master
from
jcaw:batch_consistency_different_items
Feb 28, 2021
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
36c7a08
Test with batches of differing items
jcaw d696f76
Test VAD batch consistency with differing items
jcaw c2d66dc
Generate different white noise in each channel
jcaw 08870c9
Move backend assignment after docstring
jcaw d4a66e3
Parameterize batch size in batch consistency tests
jcaw f1cbba2
Check inputs too, to catch in-place operations
jcaw f63ee8a
Don't add dimension before repeating
jcaw 235b4a3
Use much shorter sample for phaser test
jcaw 1d702e5
Pep8 formatting
jcaw 1d1baa6
Load dual-channel wav for VAD test
jcaw dfeb803
Load wav using common_utils, not torchaudio.load
jcaw 5e22b43
Remove unused import
jcaw f04bb3d
Test pitch frequency with different freqs per item
jcaw 19de2a4
Explain justification for single-item batch
jcaw 938ff4b
Do not set audio backend for VAD test from files
jcaw File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also take this opportunity to replace these waveform generation with
get_whitenoise
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing