Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-Breaking: Rename waveform tensor in F.sliding_window_cmn #1347

Merged
merged 2 commits into from Mar 9, 2021

Conversation

jcaw
Copy link
Contributor

@jcaw jcaw commented Mar 3, 2021

F.sliding_window_cmn appears to take a spectrogram as input, of shape (..., freq, time). However, the name of the argument is waveform. I discussed this briefly with @mthrok here and here. This PR changes the name of this argument to specgram. Since this is a BC-breaking change, I've opened a separate pull request.

The output tensor also appears to be a spectrogram of the same shape as the input, so I've renamed that too, and updated the specification in the docstring.

jcaw added 2 commits March 3, 2021 22:17
`F.sliding_window_cmn` takes a spectrogram as input (of shape
`(..., freq, time)`). However, this spectrogram is named `waveform`.
This appears to be an error, so rename this (and the output tensor) to
reflect that both are spectrograms.
The output tensor of `F.sliding_window_cmn` is also a spectrogram.
Update the description to reflect this.
@mthrok mthrok changed the title Rename waveform tensor in F.sliding_window_cmn BC-Breaking: Rename waveform tensor in F.sliding_window_cmn Mar 4, 2021
@mthrok mthrok merged commit ea85794 into pytorch:master Mar 9, 2021
@mthrok
Copy link
Collaborator

mthrok commented Mar 9, 2021

Thanks!

mthrok added a commit to mthrok/audio that referenced this pull request Dec 13, 2022
* Update build.sh

* Update audio tutorial for release pytorch 1.8 / torchaudio 0.8 (pytorch#1379)

* [wip] replace audio tutorial

* Update

* Update

* Update

* fixup

* Update requirements.txt

* update

* Update

Co-authored-by: Brian Johnson <brianjo@fb.com>

* [1.8 release] Switch to the new datasets in torchtext 0.9.0 release - text classification tutorial (pytorch#1352)

* switch to the new dataset API

* checkpoint

* checkpoint

* checkpoint

* update docs

* checkpoint

* switch to legacy vocab

* update to follow the master API

* checkpoint

* checkpoint

* address reviewer's comments

Co-authored-by: Guanheng Zhang <zhangguanheng@devfair0197.h2.fair>
Co-authored-by: Brian Johnson <brianjo@fb.com>

* [1.8 release] Switch to LM dataset in torchtext 0.9.0 release (pytorch#1349)

* switch to raw text dataset in torchtext 0.9.0 release

* follow the new API in torchtext master

Co-authored-by: Guanheng Zhang <zhangguanheng@devfair0197.h2.fair>
Co-authored-by: Brian Johnson <brianjo@fb.com>

* [WIP][FX] CPU Performance Profiling with FX (pytorch#1319)

Co-authored-by: Brian Johnson <brianjo@fb.com>

* [FX] Added fuser tutorial (pytorch#1356)

* Added fuser tutorial

* updated index.rst

* fixed conclusion

* responded to some comments

* responded to comments

* respond

Co-authored-by: Brian Johnson <brianjo@fb.com>

* Update numeric_suite_tutorial.py

* Tutorial combining DDP with Pipeline Parallelism to Train Transformer models (pytorch#1347)

* Tutorial combining DDP with Pipeline Parallelism to Train Transformer models.

Summary: Tutorial which places a pipe on GPUs 0 and 1 and another Pipe
on GPUs 2 and 3. Both pipe replicas are replicated via DDP. One process
drives GPUs 0 and 1 and another drives GPUs 2 and 3.

* Polish out some of the docs.

* Add thumbnail and address some comments.

Co-authored-by: pritam <pritam.damania@fb.com>

* More updates to numeric_suite

* Even more updates

* Update numeric_suite_tutorial.py

Hopefully that's the last one

* Update numeric_suite_tutorial.py

Last one

* Update build.sh

Co-authored-by: moto <855818+mthrok@users.noreply.github.com>
Co-authored-by: Guanheng George Zhang <6156351+zhangguanheng66@users.noreply.github.com>
Co-authored-by: Guanheng Zhang <zhangguanheng@devfair0197.h2.fair>
Co-authored-by: James Reed <jamesreed@fb.com>
Co-authored-by: Horace He <horacehe2007@yahoo.com>
Co-authored-by: Pritam Damania <9958665+pritamdamania87@users.noreply.github.com>
Co-authored-by: pritam <pritam.damania@fb.com>
Co-authored-by: Nikita Shulga <nshulga@fb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants