BC-Breaking: Rename waveform
tensor in F.sliding_window_cmn
#1347
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
F.sliding_window_cmn
appears to take a spectrogram as input, of shape(..., freq, time)
. However, the name of the argument iswaveform
. I discussed this briefly with @mthrok here and here. This PR changes the name of this argument tospecgram
. Since this is a BC-breaking change, I've opened a separate pull request.The output tensor also appears to be a spectrogram of the same shape as the input, so I've renamed that too, and updated the specification in the docstring.