Remove an invalid resample comparison unit test #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthrok
approved these changes
Apr 5, 2021
carolineechen
changed the title
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Apr 6, 2021
Similar to pytorch#1426 `test_InverseMelScale` in `librosa_compatibility_test` is not ensuring the comaptibility to librosa. Having this test can give a wrong statement about the librosa numerical compatibility about the function.
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Apr 7, 2021
Similar to pytorch#1426 `test_InverseMelScale` in `librosa_compatibility_test` is not ensuring the comaptibility to librosa. Having this test can give a wrong statement about the librosa numerical compatibility about the function.
mthrok
added a commit
that referenced
this pull request
Apr 7, 2021
* Remove an invalid InverseMel comparison unit test Similar to #1426 `test_InverseMelScale` in `librosa_compatibility_test` is not ensuring the comaptibility to librosa. Having this test can give a wrong statement about the librosa numerical compatibility about the function. * Add test for InverseMelScale The new test compares the result of inverse mel scale against the reference spectrogram, so no need to use librosa. This test serves as more like an insurance that the change to the implementation of InverseMelScale only improves the result, not the other way.
carolineechen
pushed a commit
to carolineechen/audio
that referenced
this pull request
Apr 30, 2021
carolineechen
pushed a commit
to carolineechen/audio
that referenced
this pull request
Apr 30, 2021
* Remove an invalid InverseMel comparison unit test Similar to pytorch#1426 `test_InverseMelScale` in `librosa_compatibility_test` is not ensuring the comaptibility to librosa. Having this test can give a wrong statement about the librosa numerical compatibility about the function. * Add test for InverseMelScale The new test compares the result of inverse mel scale against the reference spectrogram, so no need to use librosa. This test serves as more like an insurance that the change to the implementation of InverseMelScale only improves the result, not the other way.
mthrok
pushed a commit
to mthrok/audio
that referenced
this pull request
Dec 13, 2022
* Rename ddp_pipeline_tutorial.py to ddp_pipeline.py This will make this file non-executable and the code will still show up in the file. * Update build.sh * Update index.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unit test comparing librosa and torchaudio's numerical results for resampling was not correct -- resampling with a larger range of input data can result in numerical differences of greater than atol=1e-02 in the unit test, which is not enough to claim compatibility