Update InverseMelScale comparison test #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolineechen
approved these changes
Apr 6, 2021
mthrok
changed the title
Similar to pytorch#1426 `test_InverseMelScale` in `librosa_compatibility_test` is not ensuring the comaptibility to librosa. Having this test can give a wrong statement about the librosa numerical compatibility about the function.
mthrok
force-pushed
the
librosa-inversemelscale
branch
from
bd9486a
to
e700ef9
Compare
carolineechen
pushed a commit
to carolineechen/audio
that referenced
this pull request
Apr 30, 2021
* Remove an invalid InverseMel comparison unit test Similar to pytorch#1426 `test_InverseMelScale` in `librosa_compatibility_test` is not ensuring the comaptibility to librosa. Having this test can give a wrong statement about the librosa numerical compatibility about the function. * Add test for InverseMelScale The new test compares the result of inverse mel scale against the reference spectrogram, so no need to use librosa. This test serves as more like an insurance that the change to the implementation of InverseMelScale only improves the result, not the other way.
mthrok
pushed a commit
to mthrok/audio
that referenced
this pull request
Dec 13, 2022
Amended a typo in part of the description. Co-authored-by: Brian Johnson <brianjo@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the existing test for InverseMelScale in
librosa_compatibliity_testwith a new test.Similar to #1426,
test_InverseMelScaleinlibrosa_compatibility_testis notensuring the comaptibility to librosa. Having this test can give a wrong statement
about the librosa numerical compatibility of the function.
The new test compares the result of inverse mel scale against the reference spectrogram, so no need to use librosa.
This test serves as more like an insurance that the change to the implementation of
InverseMelScaleonly improves the result, not the other way.