Add autograd test for T.AmplitudeToDB #1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthrok
reviewed
Apr 12, 2021
| sample_rate = 8000 | ||
| transform = T.AmplitudeToDB() | ||
| waveform = get_whitenoise(sample_rate=sample_rate, duration=0.05, n_channels=2) | ||
| self.assert_grad(transform, [waveform], nondet_tol=1e-10) |
There was a problem hiding this comment.
Did you try it without nonfat_tol?
With top_db=None, it's just a combination of log10, clamp and multiplications.
If any of them are non deterministic, would be nice to add a comment about it here.
Also can you parameterize top_db? Say, None and 80 as recommended by the doc.
audio/torchaudio/functional/functional.py
Line 280 in 78c3480
There was a problem hiding this comment.
My bad, I realized that when top_db is provided the function uses torch.amax, which is not differentiable. I think we should only test for the case top_db=None.
There was a problem hiding this comment.
Just made those changes let me know if this is okay.
carolineechen
pushed a commit
to carolineechen/audio
that referenced
this pull request
Apr 30, 2021
mthrok
pushed a commit
to mthrok/audio
that referenced
this pull request
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #1414
cc @mthrok