Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add autograd test for T.AmplitudeToDB #1447

Merged
merged 4 commits into from
Apr 13, 2021
Merged

Add autograd test for T.AmplitudeToDB #1447

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
da1546b
amp to db
krishnakalyan3 Apr 11, 2021
3db9a8e
add params and review feedback
krishnakalyan3 Apr 13, 2021
adfefd8
test failure
krishnakalyan3 Apr 13, 2021
796914f
revert changes
krishnakalyan3 Apr 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions test/torchaudio_unittest/transforms/autograd_test_impl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,3 +123,9 @@ def test_spectral_centroid(self):
transform = T.SpectralCentroid(sample_rate=sample_rate)
waveform = get_whitenoise(sample_rate=sample_rate, duration=0.05, n_channels=2)
self.assert_grad(transform, [waveform], nondet_tol=1e-10)

def test_amplitude_to_db(self):
sample_rate = 8000
transform = T.AmplitudeToDB()
waveform = get_whitenoise(sample_rate=sample_rate, duration=0.05, n_channels=2)
self.assert_grad(transform, [waveform], nondet_tol=1e-10)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try it without nonfat_tol?
With top_db=None, it's just a combination of log10, clamp and multiplications.
If any of them are non deterministic, would be nice to add a comment about it here.

Also can you parameterize top_db? Say, None and 80 as recommended by the doc.

audio/torchaudio/functional/functional.py

Line 280 in 78c3480

if top_db is not None:

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krishnakalyan3

My bad, I realized that when top_db is provided the function uses torch.amax, which is not differentiable. I think we should only test for the case top_db=None.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just made those changes let me know if this is okay.